From: "Ernesto A. Fernández" <ernesto.mnd.fernandez@gmail.com>
To: Jan Kara <jack@suse.cz>
Cc: linux-fsdevel@vger.kernel.org, "Jan Kara" <jack@suse.cz>,
"Andreas Gruenbacher" <agruenba@redhat.com>,
"Alexander Viro" <viro@zeniv.linux.org.uk>,
"Christoph Hellwig" <hch@infradead.org>,
"Vyacheslav Dubeyko" <slava@dubeyko.com>,
"Ernesto A. Fernández" <ernesto.mnd.fernandez@gmail.com>
Subject: Re: [PATCH 2/2] hfsplus: add mount option to enable ACL support
Date: Thu, 27 Jul 2017 18:29:50 -0300 [thread overview]
Message-ID: <20170727212948.GA3048@debian.home> (raw)
In-Reply-To: <20170727094147.GE21100@quack2.suse.cz>
On Thu, Jul 27, 2017 at 11:41:47AM +0200, Jan Kara wrote:
> On Thu 27-07-17 00:13:54, Ernesto A. Fernández wrote:
> > The hfsplus module already has the code to support access control
> > lists, but there is no corresponding mount option. Add it and keep it
> > disabled by default.
>
> Hum, this seems to be a regression caused by Christoph's ACL rework in
> 2013. Since then HFS+ acls didn't work. So much for how much they are
> used... Maybe time to drop the feature when nobody noticed it does not work
> for 4 years?
I'm not sure the lack of use is a problem of ACLs in particular. I quickly
ran into trouble with extended attributes as well, so my guess is that all
of the module gets very limited use. I'll try and send some patches as
soon as I can.
next prev parent reply other threads:[~2017-07-27 21:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-27 3:10 [PATCH 1/2] hfsplus: preserve i_mode if __hfsplus_set_posix_acl() fails Ernesto A. Fernández
2017-07-27 3:13 ` [PATCH 2/2] hfsplus: add mount option to enable ACL support Ernesto A. Fernández
2017-07-27 9:41 ` Jan Kara
2017-07-27 9:50 ` Christoph Hellwig
2017-10-14 2:43 ` Ernesto A. Fernández
2017-10-16 7:42 ` Christoph Hellwig
2017-10-16 15:50 ` Viacheslav Dubeyko
2017-10-17 7:53 ` Jan Kara
2017-10-17 8:03 ` Christoph Hellwig
2017-10-17 15:20 ` Viacheslav Dubeyko
2017-07-27 21:29 ` Ernesto A. Fernández [this message]
2017-07-27 9:18 ` [PATCH 1/2] hfsplus: preserve i_mode if __hfsplus_set_posix_acl() fails Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170727212948.GA3048@debian.home \
--to=ernesto.mnd.fernandez@gmail.com \
--cc=agruenba@redhat.com \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=slava@dubeyko.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.