From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Boyd <sboyd@codeaurora.org>
Subject: Re: [PATCH V1 03/12] spmi: pmic-arb: clean up pmic_arb_find_apid
 function
Date: Thu, 27 Jul 2017 18:18:05 -0700
Message-ID: <20170728011805.GX2146@codeaurora.org>
References: <1500535910-28705-1-git-send-email-kgunda@codeaurora.org>
 <1500535910-28705-4-git-send-email-kgunda@codeaurora.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <linux-kernel-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <1500535910-28705-4-git-send-email-kgunda@codeaurora.org>
Sender: linux-kernel-owner@vger.kernel.org
To: Kiran Gunda <kgunda@codeaurora.org>
Cc: gregkh@linuxfoundation.org, Abhijeet Dharmapurikar <adharmap@codeaurora.org>, David Collins <collinsd@codeaurora.org>, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
List-Id: linux-arm-msm@vger.kernel.org

On 07/20, Kiran Gunda wrote:
> Clean up the pmic_arb_find_apid() by using the local
> variables to improve the code readability.
> 
> Signed-off-by: Kiran Gunda <kgunda@codeaurora.org>
> ---

Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>

One nit below:

>  			break;
>  
>  		regval = readl_relaxed(pmic_arb->cnfg +
> -				      SPMI_OWNERSHIP_TABLE_REG(apid));
> -		pmic_arb->apid_data[apid].owner =
> -					SPMI_OWNERSHIP_PERIPH2OWNER(regval);
> +					SPMI_OWNERSHIP_TABLE_REG(apid));

This should be 7 spaces and not a tab? Originally looks like it
was 6 spaces

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project