From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57818) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1db4kI-0005wr-Ff for qemu-devel@nongnu.org; Fri, 28 Jul 2017 08:51:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1db4kH-0001Kx-Q5 for qemu-devel@nongnu.org; Fri, 28 Jul 2017 08:51:58 -0400 Date: Fri, 28 Jul 2017 14:48:33 +0200 From: Olaf Hering Message-ID: <20170728124832.GP8603@aepfle.de> References: <20170728123127.27921-1-olaf@aepfle.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="TSQPSNmi3T91JED+" Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH] xen-disk: use g_malloc0 to fix build List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: Stefano Stabellini , Anthony Perard , Kevin Wolf , Max Reitz , "open list:X86" , "open list:Block layer core" , "open list:All patches CC here" --TSQPSNmi3T91JED+ Content-Type: text/plain; charset=utf-8 Content-Disposition: inline On Fri, Jul 28, Eric Blake wrote: > This version is prone to multiplication overflow (well, maybe not, but > you have to audit for that). Wouldn't it be better to use: What could go wrong? qemu will die either way, I think. Olaf --TSQPSNmi3T91JED+ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EARECAB0WIQSkRyP6Rn//f03pRUBdQqD6ppg2fgUCWXsyjAAKCRBdQqD6ppg2 fpYMAKDNcY2BWV607m3JyjhuvvIbcy8hmwCg6jNjYA+4wPjqQ+jKQH85nvn7ypU= =NXQZ -----END PGP SIGNATURE----- --TSQPSNmi3T91JED+-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olaf Hering Subject: Re: [Qemu-devel] [PATCH] xen-disk: use g_malloc0 to fix build Date: Fri, 28 Jul 2017 14:48:33 +0200 Message-ID: <20170728124832.GP8603@aepfle.de> References: <20170728123127.27921-1-olaf@aepfle.de> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8442830214973474136==" Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1db4h6-0002Sh-Ii for xen-devel@lists.xenproject.org; Fri, 28 Jul 2017 12:48:40 +0000 In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Eric Blake Cc: Kevin Wolf , Stefano Stabellini , "open list:Block layer core" , "open list:All patches CC here" , Max Reitz , Anthony Perard , "open list:X86" List-Id: xen-devel@lists.xenproject.org --===============8442830214973474136== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="TSQPSNmi3T91JED+" Content-Disposition: inline --TSQPSNmi3T91JED+ Content-Type: text/plain; charset=utf-8 Content-Disposition: inline On Fri, Jul 28, Eric Blake wrote: > This version is prone to multiplication overflow (well, maybe not, but > you have to audit for that). Wouldn't it be better to use: What could go wrong? qemu will die either way, I think. Olaf --TSQPSNmi3T91JED+ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EARECAB0WIQSkRyP6Rn//f03pRUBdQqD6ppg2fgUCWXsyjAAKCRBdQqD6ppg2 fpYMAKDNcY2BWV607m3JyjhuvvIbcy8hmwCg6jNjYA+4wPjqQ+jKQH85nvn7ypU= =NXQZ -----END PGP SIGNATURE----- --TSQPSNmi3T91JED+-- --===============8442830214973474136== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg== --===============8442830214973474136==--