From: Cornelia Huck <cohuck@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Cc: qemu-devel@nongnu.org, mreitz@redhat.com, den@openvz.org,
pbonzini@redhat.com, jsnow@redhat.com
Subject: Re: [Qemu-devel] [PATCH] trace-events: print 0x before hex numbers
Date: Fri, 28 Jul 2017 13:30:35 +0200 [thread overview]
Message-ID: <20170728133035.4eb78e5a@gondolin> (raw)
In-Reply-To: <f4ae26f2-fd4f-1b38-e20a-1d6ff4844b64@virtuozzo.com>
On Fri, 28 Jul 2017 13:01:15 +0300
Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> wrote:
> 28.07.2017 12:41, Cornelia Huck wrote:
> > On Fri, 28 Jul 2017 11:55:47 +0300
> > Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> wrote:
> >
> >> To make logs more readable prefix all hex values with '0x' mark.
> >> This is needed for consistency too, as a lot of hex values are already
> >> prefixed with '0x'. Also, bring all hex outputs to the common form -
> >> use '%#', not '0x%'.
> > This is problematic if you try to match up things in the trace with
> > things that don't have the leading 0x elsewhere. See my comments on the
> > s390x changes below.
>
> Hmm, not so easy..
>
> All your remarks satisfy the following criteria (and it seems logical
> anyway):
>
> hex numbers grouped into patterns like NUM.NUM.NUM (several numbers
> splitted by period) are allowed to be printed without 0x prefixes.
Works for me. There might be other similar patterns, though.
next prev parent reply other threads:[~2017-07-28 11:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-28 8:55 [Qemu-devel] [PATCH] trace-events: print 0x before hex numbers Vladimir Sementsov-Ogievskiy
2017-07-28 9:04 ` Peter Maydell
2017-07-28 9:19 ` Vladimir Sementsov-Ogievskiy
2017-07-28 12:08 ` Eric Blake
2017-07-28 12:19 ` Peter Maydell
2017-07-28 12:40 ` Eric Blake
2017-07-28 9:06 ` Daniel P. Berrange
2017-07-28 9:14 ` Vladimir Sementsov-Ogievskiy
2017-07-28 9:41 ` Cornelia Huck
2017-07-28 10:01 ` Vladimir Sementsov-Ogievskiy
2017-07-28 11:30 ` Cornelia Huck [this message]
2017-07-28 12:05 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170728133035.4eb78e5a@gondolin \
--to=cohuck@redhat.com \
--cc=den@openvz.org \
--cc=jsnow@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.