All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Egil Hjelmeland <privat@egil-hjelmeland.no>
Cc: vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel@pengutronix.de
Subject: Re: [PATCH net-next 2/4] net: dsa: lan9303: Multiply by 4 to get MDIO register
Date: Fri, 28 Jul 2017 17:20:37 +0200	[thread overview]
Message-ID: <20170728152037.GF2132@lunn.ch> (raw)
In-Reply-To: <20170728151157.28983-3-privat@egil-hjelmeland.no>

On Fri, Jul 28, 2017 at 05:11:55PM +0200, Egil Hjelmeland wrote:
> lan9303_mdio_write()/_read() must multiply register number by 4 to get
> offset.
> 
> Added some commments to the register definitions.
> 
> Signed-off-by: Egil Hjelmeland <privat@egil-hjelmeland.no>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

  reply	other threads:[~2017-07-28 15:20 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-28 15:11 [PATCH net-next 0/4] net: dsa: lan9303: Fix MDIO issues Egil Hjelmeland
2017-07-28 15:11 ` [PATCH net-next 1/4] net: dsa: lan9303: Fix lan9303_detect_phy_setup() for MDIO Egil Hjelmeland
2017-07-28 15:19   ` Andrew Lunn
2017-07-28 15:36   ` Vivien Didelot
2017-07-28 17:02   ` Florian Fainelli
2017-07-28 15:11 ` [PATCH net-next 2/4] net: dsa: lan9303: Multiply by 4 to get MDIO register Egil Hjelmeland
2017-07-28 15:20   ` Andrew Lunn [this message]
2017-07-28 15:37   ` Vivien Didelot
2017-07-28 17:02   ` Florian Fainelli
2017-07-28 15:11 ` [PATCH net-next 3/4] net: dsa: lan9303: Renamed indirect phy access functions Egil Hjelmeland
2017-07-28 15:22   ` Andrew Lunn
2017-07-28 15:37   ` Vivien Didelot
2017-07-28 17:03   ` Florian Fainelli
2017-07-28 15:11 ` [PATCH net-next 4/4] net: dsa: lan9303: MDIO access phy registers directly Egil Hjelmeland
2017-07-28 15:24   ` Andrew Lunn
2017-07-28 15:39   ` Vivien Didelot
2017-07-28 16:24     ` Egil Hjelmeland
2017-07-28 16:55       ` Vivien Didelot
2017-07-28 17:05         ` Florian Fainelli
2017-07-28 19:44           ` Egil Hjelmeland
2017-07-28 21:28             ` Andrew Lunn
2017-07-28 22:30               ` Egil Hjelmeland
2017-07-31 11:44           ` David Laight
2017-07-28 15:24 ` [PATCH net-next 0/4] net: dsa: lan9303: Fix MDIO issues Andrew Lunn
2017-07-28 16:33   ` Egil Hjelmeland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170728152037.GF2132@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=f.fainelli@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=privat@egil-hjelmeland.no \
    --cc=vivien.didelot@savoirfairelinux.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.