All of lore.kernel.org
 help / color / mirror / Atom feed
From: Venu Busireddy <venu.busireddy@oracle.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
	Ian Jackson <ian.jackson@eu.citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	xen-devel@lists.xen.org
Subject: Re: [PATCH v2 2/2] xl: Register the AER event handler to handle AER errors.
Date: Fri, 28 Jul 2017 09:06:03 -0700	[thread overview]
Message-ID: <20170728160603.GA1518@fett.us.oracle.com> (raw)
In-Reply-To: <20170728155816.udwa77tazoraujxl@citrix.com>

On 2017-07-28 16:58:16 +0100, Wei Liu wrote:
> On Wed, Jul 26, 2017 at 07:16:39PM -0500, Venu Busireddy wrote:
> > When a guest is created, register the AER event handler to handle the
> > AER errors. When an AER error occurs, the handler will forcibly remove
> > the erring PCIe device from the guest.
> > 
> > Signed-off-by: Venu Busireddy <venu.busireddy@oracle.com>
> > ---
> >  tools/xl/xl_vmcontrol.c | 11 +++++++++++
> >  1 file changed, 11 insertions(+)
> > 
> > diff --git a/tools/xl/xl_vmcontrol.c b/tools/xl/xl_vmcontrol.c
> > index 89c2b25..10a48a9 100644
> > --- a/tools/xl/xl_vmcontrol.c
> > +++ b/tools/xl/xl_vmcontrol.c
> > @@ -966,6 +966,15 @@ start:
> >      LOG("Waiting for domain %s (domid %u) to die [pid %ld]",
> >          d_config.c_info.name, domid, (long)getpid());
> >  
> > +    ret = libxl_reg_aer_events_handler(ctx, domid);
> > +    if (ret) {
> > +        /*
> > +         * This error may not be severe enough to fail the creation of the VM.
> > +         * Log the error, and continue with the creation.
> > +         */
> 
> What does this comment mean? This is called after the guest is created,
> right?

Maybe too many words. I can change it as:

/* Log the error, and move on...  */

Is that okay?

Venu


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  reply	other threads:[~2017-07-28 16:06 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-27  0:16 [PATCH v2 0/2] Containing AER unrecoverable errors Venu Busireddy
2017-07-27  0:16 ` [PATCH v2 1/2] libxl: Implement the handler to handle unrecoverable AER errors Venu Busireddy
2017-07-28 15:58   ` Wei Liu
2017-07-28 17:15     ` Venu Busireddy
2017-07-31 14:37       ` Wei Liu
2017-07-28 16:39   ` Ian Jackson
2017-07-28 23:56     ` Venu Busireddy
2017-07-31 15:03       ` Wei Liu
2017-07-27  0:16 ` [PATCH v2 2/2] xl: Register the AER event handler to handle " Venu Busireddy
2017-07-28 15:58   ` Wei Liu
2017-07-28 16:06     ` Venu Busireddy [this message]
2017-07-28 16:14       ` Wei Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170728160603.GA1518@fett.us.oracle.com \
    --to=venu.busireddy@oracle.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=jbeulich@suse.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.