From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753820AbdG2NeL (ORCPT <rfc822;w@1wt.eu>);
        Sat, 29 Jul 2017 09:34:11 -0400
Received: from out1-smtp.messagingengine.com ([66.111.4.25]:36737 "EHLO
        out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1753778AbdG2NeJ (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 29 Jul 2017 09:34:09 -0400
X-ME-Sender: <xms:0I58WZmCJc7q2qqA60jpLAr3MutrJusaKEwUhy7wYPu5rE9EwVQxQw>
X-Sasl-enc: ACEDHmg9aBrLw8mtP8BeAPkmSoZC2aD1MO1DLMf6MFn9 1501335248
Date: Sat, 29 Jul 2017 06:34:03 -0700
From: Greg KH <greg@kroah.com>
To: Lu Baolu <baolu.lu@linux.intel.com>
Cc: Mathias Nyman <mathias.nyman@linux.intel.com>,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] usb: xhci: Add debugfs interface for xHCI driver
Message-ID: <20170729133403.GB8007@kroah.com>
References: <1501316283-8604-1-git-send-email-baolu.lu@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1501316283-8604-1-git-send-email-baolu.lu@linux.intel.com>
User-Agent: Mutt/1.8.3 (2017-05-23)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Jul 29, 2017 at 04:18:03PM +0800, Lu Baolu wrote:
> +static void xhci_debugfs_create_files(struct xhci_hcd *xhci,
> +				      struct xhci_file_map *files,
> +				      size_t nentries, void *data,
> +				      struct dentry *parent,
> +				      const struct file_operations *fops)
> +{
> +	int			i;
> +	struct dentry		*file;
> +
> +	for (i = 0; i < nentries; i++) {
> +		file = debugfs_create_file(files[i].name, 0444,
> +					   parent, data, fops);
> +		if (IS_ERR_OR_NULL(file))
> +			break;

There's no need to ever check the return value of a debugfs_ function,
there's nothing you can do here, just keep calling it :)

And you will not get an error, you will only get NULL if there is an
error, as the only error you would get is if debugfs was not enabled.

> +static struct dentry *xhci_debugfs_create_ring_dir(struct xhci_hcd *xhci,
> +						   struct xhci_ring *ring,
> +						   const char *name,
> +						   struct dentry *parent)
> +{
> +	struct dentry		*dir;
> +
> +	dir = debugfs_create_dir(name, parent);
> +	if (IS_ERR_OR_NULL(dir))
> +		return NULL;

Same here.  Just keep going, you don't care about the return value, but
you can use it safely no matter what.


Same for other places in this patch as well.

thanks,

greg k-h