All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Patrice Chotard <patrice.chotard@st.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	linux-gpio@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org,
	Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Subject: [PATCH] pinctrl-st: fix of_irq_to_resource() result check
Date: Sat, 29 Jul 2017 21:07:07 +0300	[thread overview]
Message-ID: <20170729180744.873303067@cogentembedded.com> (raw)

[-- Attachment #1: pinctrl-st-fix-of_irq_to_resource-result-check.patch --]
[-- Type: text/plain, Size: 978 bytes --]

of_irq_to_resource() has recently been fixed to return negative error #'s
along with 0 in case of failure, however the ST driver still only regards
0 as failure indication -- fix it up.

Fixes: 7a4228bbff76 ("of: irq: use of_irq_get() in of_irq_to_resource()")
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

---
 drivers/pinctrl/pinctrl-st.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-pinctrl/drivers/pinctrl/pinctrl-st.c
===================================================================
--- linux-pinctrl.orig/drivers/pinctrl/pinctrl-st.c
+++ linux-pinctrl/drivers/pinctrl/pinctrl-st.c
@@ -1521,7 +1521,7 @@ static int st_gpiolib_register_bank(stru
 	 *	[irqN]----> [gpio-bank (n)]
 	 */
 
-	if (of_irq_to_resource(np, 0, &irq_res)) {
+	if (of_irq_to_resource(np, 0, &irq_res) > 0) {
 		gpio_irq = irq_res.start;
 		gpiochip_set_chained_irqchip(&bank->gpio_chip, &st_gpio_irqchip,
 					     gpio_irq, st_gpio_irq_handler);


WARNING: multiple messages have this Message-ID (diff)
From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] pinctrl-st: fix of_irq_to_resource() result check
Date: Sat, 29 Jul 2017 21:07:07 +0300	[thread overview]
Message-ID: <20170729180744.873303067@cogentembedded.com> (raw)

of_irq_to_resource() has recently been fixed to return negative error #'s
along with 0 in case of failure, however the ST driver still only regards
0 as failure indication -- fix it up.

Fixes: 7a4228bbff76 ("of: irq: use of_irq_get() in of_irq_to_resource()")
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

---
 drivers/pinctrl/pinctrl-st.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-pinctrl/drivers/pinctrl/pinctrl-st.c
===================================================================
--- linux-pinctrl.orig/drivers/pinctrl/pinctrl-st.c
+++ linux-pinctrl/drivers/pinctrl/pinctrl-st.c
@@ -1521,7 +1521,7 @@ static int st_gpiolib_register_bank(stru
 	 *	[irqN]----> [gpio-bank (n)]
 	 */
 
-	if (of_irq_to_resource(np, 0, &irq_res)) {
+	if (of_irq_to_resource(np, 0, &irq_res) > 0) {
 		gpio_irq = irq_res.start;
 		gpiochip_set_chained_irqchip(&bank->gpio_chip, &st_gpio_irqchip,
 					     gpio_irq, st_gpio_irq_handler);

             reply	other threads:[~2017-07-29 18:07 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-29 18:07 Sergei Shtylyov [this message]
2017-07-29 18:07 ` [PATCH] pinctrl-st: fix of_irq_to_resource() result check Sergei Shtylyov
2017-07-29 19:15 ` Sergei Shtylyov
2017-07-29 19:15   ` Sergei Shtylyov
2017-07-31 11:27 ` Thierry Reding
2017-07-31 11:27   ` Thierry Reding
2017-07-31 11:56   ` Sergei Shtylyov
2017-07-31 11:56     ` Sergei Shtylyov
2017-08-07  9:05 ` Linus Walleij
2017-08-07  9:05   ` Linus Walleij
2017-08-07  9:56   ` Sergei Shtylyov
2017-08-07  9:56     ` Sergei Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170729180744.873303067@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=patrice.chotard@st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.