From mboxrd@z Thu Jan  1 00:00:00 1970
From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Subject: Re: [PATCH v2 0/6] fix ethdev device detach
Date: Mon, 31 Jul 2017 10:57:27 +0200
Message-ID: <20170731085727.GM19852@6wind.com>
References: <cover.1501075226.git.gaetan.rivet@6wind.com>
 <cover.1501076035.git.gaetan.rivet@6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org, Thomas Monjalon <thomas@monjalon.net>,
 Shachar Beiser <shacharbe@mellanox.com>,
 Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
To: Gaetan Rivet <gaetan.rivet@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47])
 by dpdk.org (Postfix) with ESMTP id 5F2F199A1
 for <dev@dpdk.org>; Mon, 31 Jul 2017 10:57:37 +0200 (CEST)
Received: by mail-wm0-f47.google.com with SMTP id t201so43000902wmt.0
 for <dev@dpdk.org>; Mon, 31 Jul 2017 01:57:37 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <cover.1501076035.git.gaetan.rivet@6wind.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, Jul 26, 2017 at 03:35:51PM +0200, Gaetan Rivet wrote:
> Device detach in librte_ether is rough right now.
> 
>  - Device hotplug capability is not properly checked
>  - Device state should be set after a successful detach
>  - MLX drivers are lacking the relevant flag
>  - And this flag should actually be removed, thus occuring an API change
>    for v17.11. An announce follows.
> 
> Without this series on an MLX4 port:
> 
>    testpmd> port close 0
>    Closing ports...
>    Port 0 is now not stopped
>    Done
>    testpmd> port stop 0
>    Stopping ports...
>    Checking link statuses...
>    Done
>    testpmd> port close 0
>    Closing ports...
>    Done
>    testpmd> port detach 0
>    Detaching a port...
>    testpmd> show port info 0
>    Segmentation fault (core dumped)
> 
> With this series:
> 
>    testpmd> port stop 0
>    Stopping ports...
>    Checking link statuses...
>    Done
>    testpmd> port detach 0
>    Detaching a port...
>    Please close port first
>    testpmd> port close 0
>    Closing ports...
>    Done
>    testpmd> port detach 0
>    Detaching a port...
>    Port '00:03.0' is detached. Now total ports is 0
>    Done
>    testpmd> show port info 0
>    Invalid port 0
>    Valid port range is [0]
> 
> v2:
> 
>   - remove coredump from patchset
> 
> Gaetan Rivet (6):
>   ethdev: fix device state on detach
>   ethdev: properly check detach capability
>   net/mlx4: advertize the detach capability
>   net/mlx5: advertize the detach capability
>   app/testpmd: let the user know device detach failed
>   doc: announce ethdev API change for detach flag
> 
>  app/test-pmd/testpmd.c               |  9 ++++++---
>  doc/guides/rel_notes/deprecation.rst |  6 ++++++
>  drivers/net/mlx4/mlx4.c              |  1 +
>  drivers/net/mlx5/mlx5.c              |  1 +
>  lib/librte_ether/rte_ethdev.c        | 11 +----------
>  5 files changed, 15 insertions(+), 13 deletions(-)
> 
> -- 
> 2.1.4
> 

Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>

-- 
Adrien Mazarguil
6WIND