From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean Delvare Subject: Re: [PATCH 6/8] dmi: Move memdev_dmi_entry definition to dmi.h (v2) Date: Mon, 31 Jul 2017 10:36:05 +0200 Message-ID: <20170731103605.1810e281@endymion> References: <20160308133713.24e0b71a@endymion> <1457461957-23029-1-git-send-email-matthew.d.roper@intel.com> <20160317151820.28fe70da@endymion> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 82E326E555 for ; Mon, 31 Jul 2017 08:36:09 +0000 (UTC) In-Reply-To: <20160317151820.28fe70da@endymion> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Matt Roper Cc: intel-gfx@lists.freedesktop.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, Mauro Carvalho Chehab List-Id: intel-gfx@lists.freedesktop.org SGkgTWF0dCwgTWF1cm8sCgpPbiBUaHUsIDE3IE1hciAyMDE2IDE1OjE4OjIwICswMTAwLCBKZWFu IERlbHZhcmUgd3JvdGU6Cj4gT24gVHVlLCAgOCBNYXIgMjAxNiAxMDozMjozNyAtMDgwMCwgTWF0 dCBSb3BlciB3cm90ZToKPiA+IEEgY291cGxlIG9mIHRoZSBFREFDIGRyaXZlcnMgaGF2ZSBhIG5p Y2UgbWVtZGV2X2RtaV9lbnRyeSBzdHJ1Y3R1cmUgZm9yCj4gPiBkZWNvZGluZyBETUkgbWVtb3J5 IGRldmljZSBlbnRyaWVzLiAgTW92ZSB0aGUgc3RydWN0dXJlIGRlZmluaXRpb24gdG8KPiA+IGRt aS5oIHNvIHRoYXQgaXQgY2FuIGJlIHNoYXJlZCBiZXR3ZWVuIHRob3NlIGRyaXZlcnMgYW5kIGFs c28gb3RoZXIKPiA+IHBhcnRzIG9mIHRoZSBrZXJuZWw7IHRoZSBpOTE1IGdyYXBoaWNzIGRyaXZl ciBpcyBnb2luZyB0byBuZWVkIHRvIHVzZQo+ID4gdGhpcyBzdHJ1Y3R1cmUgc29vbiBhcyB3ZWxs LiAgQXMgcGFydCBvZiB0aGlzIG1vdmUgd2UgcmVuYW1lIHRoZQo+ID4gc3RydWN0dXJlIHMvbWVt ZGV2X2RtaV9lbnRyeS9kbWlfZW50cnlfbWVtZGV2LyB0byBlbnN1cmUgaXQgaGFzIGEgcHJvcGVy Cj4gPiAnZG1pJyBwcmVmaXguCj4gPiAKPiA+IHYyOgo+ID4gIC0gUmVuYW1lIHN0cnVjdHVyZSB0 byBkbWlfZW50cnlfbWVtZGV2LiAgKEplYW4pCj4gPiAgLSBVc2UgX19wYWNrZWQgaW5zdGVhZCBv ZiBfX2F0dHJpYnV0ZV9fKChfX3BhY2tlZF9fKSkgZm9yIGNvbnNpc3RlbmN5Cj4gPiAgICB3aXRo IHRoZSByZXN0IG9mIHRoZSBkbWkuaCBoZWFkZXIuICAoSmVhbikgIAo+IAo+IExvb2tzIGJldHRl ci4gKC4uLikKCldoYXQgaGFwcGVuZWQgdG8gdGhpcyBwYXRjaD8gSSBuZXZlciByZWNlaXZlZCB2 My4gSXMgaXQgc2lsbCBuZWVkZWQ/CgotLSAKSmVhbiBEZWx2YXJlClNVU0UgTDMgU3VwcG9ydApf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZngg bWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751993AbdGaIgK (ORCPT ); Mon, 31 Jul 2017 04:36:10 -0400 Received: from mx2.suse.de ([195.135.220.15]:60958 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750969AbdGaIgI (ORCPT ); Mon, 31 Jul 2017 04:36:08 -0400 Date: Mon, 31 Jul 2017 10:36:05 +0200 From: Jean Delvare To: Matt Roper Cc: intel-gfx@lists.freedesktop.org, Mauro Carvalho Chehab , linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 6/8] dmi: Move memdev_dmi_entry definition to dmi.h (v2) Message-ID: <20170731103605.1810e281@endymion> In-Reply-To: <20160317151820.28fe70da@endymion> References: <20160308133713.24e0b71a@endymion> <1457461957-23029-1-git-send-email-matthew.d.roper@intel.com> <20160317151820.28fe70da@endymion> Organization: SUSE Linux X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.31; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Matt, Mauro, On Thu, 17 Mar 2016 15:18:20 +0100, Jean Delvare wrote: > On Tue, 8 Mar 2016 10:32:37 -0800, Matt Roper wrote: > > A couple of the EDAC drivers have a nice memdev_dmi_entry structure for > > decoding DMI memory device entries. Move the structure definition to > > dmi.h so that it can be shared between those drivers and also other > > parts of the kernel; the i915 graphics driver is going to need to use > > this structure soon as well. As part of this move we rename the > > structure s/memdev_dmi_entry/dmi_entry_memdev/ to ensure it has a proper > > 'dmi' prefix. > > > > v2: > > - Rename structure to dmi_entry_memdev. (Jean) > > - Use __packed instead of __attribute__((__packed__)) for consistency > > with the rest of the dmi.h header. (Jean) > > Looks better. (...) What happened to this patch? I never received v3. Is it sill needed? -- Jean Delvare SUSE L3 Support