From: Jiri Pirko <jiri@resnulli.us>
To: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
xiyou.wangcong@gmail.com, daniel@iogearbox.net,
mlxsw@mellanox.com
Subject: Re: [patch net-next 04/20] net: sched: use tcf_exts_has_actions in tcf_exts_exec
Date: Mon, 31 Jul 2017 14:23:20 +0200 [thread overview]
Message-ID: <20170731122320.GE1883@nanopsycho> (raw)
In-Reply-To: <01a0f827-1a9d-d8fa-f2b1-1c3ab65c4352@mojatatu.com>
Mon, Jul 31, 2017 at 02:09:22PM CEST, jhs@mojatatu.com wrote:
>On 17-07-31 02:36 AM, Jiri Pirko wrote:
>> Sun, Jul 30, 2017 at 09:48:24PM CEST, jhs@mojatatu.com wrote:
>> > I am probably missing something. All those changes to just
>> > replace "if (exts->nr_actions)" with "if (tcf_exts_has_actions(exts))" ?
>>
>> That is what the description says :)
>>
>
>I meant I wouldve expected few liners added/removed.
one actually. But the function tcf_exts_exec had to be moved since
tcf_exts_has_actions was defined after originaly
>
>cheers,
>jamal
next prev parent reply other threads:[~2017-07-31 12:23 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-28 14:40 [patch net-next 00/20] net: sched: summer cleanup part 1, mainly in exts area Jiri Pirko
2017-07-28 14:40 ` [patch net-next 01/20] net: sched: sch_atm: use Qdisc_class_common structure Jiri Pirko
2017-07-30 19:04 ` Jamal Hadi Salim
2017-07-28 14:40 ` [patch net-next 02/20] net: sched: remove unneeded tcf_em_tree_change Jiri Pirko
2017-07-28 14:40 ` [patch net-next 03/20] net: sched: change names of action number helpers to be aligned with the rest Jiri Pirko
2017-07-30 19:46 ` Jamal Hadi Salim
2017-07-28 14:40 ` [patch net-next 04/20] net: sched: use tcf_exts_has_actions in tcf_exts_exec Jiri Pirko
2017-07-30 19:48 ` Jamal Hadi Salim
2017-07-31 6:36 ` Jiri Pirko
2017-07-31 12:09 ` Jamal Hadi Salim
2017-07-31 12:23 ` Jiri Pirko [this message]
2017-07-31 20:37 ` Cong Wang
2017-08-01 4:53 ` Jiri Pirko
2017-07-28 14:40 ` [patch net-next 05/20] net: sched: remove redundant helpers tcf_exts_is_predicative and tcf_exts_is_available Jiri Pirko
2017-07-28 14:40 ` [patch net-next 06/20] net: sched: fix return value of tcf_exts_exec Jiri Pirko
2017-07-28 14:40 ` [patch net-next 07/20] net: sched: remove check for number of actions in tcf_exts_exec Jiri Pirko
2017-07-28 14:40 ` [patch net-next 08/20] net: sched: use tcf_exts_has_actions instead of exts->nr_actions Jiri Pirko
2017-07-28 14:40 ` [patch net-next 09/20] net: sched: convert actions array into rcu list Jiri Pirko
2017-07-30 20:17 ` Jamal Hadi Salim
2017-07-31 21:07 ` Cong Wang
2017-08-01 4:59 ` Jiri Pirko
2017-07-28 14:40 ` [patch net-next 10/20] net: sched: cls_bpf: rename cls_bpf_modify_existing function Jiri Pirko
2017-07-31 9:30 ` Daniel Borkmann
2017-07-28 14:40 ` [patch net-next 11/20] net: sched: cls_fw: rename fw_change_attrs function Jiri Pirko
2017-07-28 14:40 ` [patch net-next 12/20] net: sched: cls_flower: no need to call tcf_exts_change for newly allocated struct Jiri Pirko
2017-07-28 14:40 ` [patch net-next 13/20] net: sched: cls_fw: " Jiri Pirko
2017-07-28 14:40 ` [patch net-next 14/20] net: sched: cls_matchall: " Jiri Pirko
2017-07-28 14:40 ` [patch net-next 15/20] net: sched: cls_basic: " Jiri Pirko
2017-07-28 14:40 ` [patch net-next 16/20] net: sched: cls_bpf: " Jiri Pirko
2017-07-31 10:02 ` Daniel Borkmann
2017-07-28 14:40 ` [patch net-next 17/20] net: sched: cls_cgroup: " Jiri Pirko
2017-07-28 14:40 ` [patch net-next 18/20] net: sched: cls_flow: " Jiri Pirko
2017-07-28 14:40 ` [patch net-next 19/20] net: sched: cls_route: " Jiri Pirko
2017-07-28 14:40 ` [patch net-next 20/20] net: sched: cls_u32: " Jiri Pirko
2017-07-31 21:35 ` [patch net-next 00/20] net: sched: summer cleanup part 1, mainly in exts area David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170731122320.GE1883@nanopsycho \
--to=jiri@resnulli.us \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=jhs@mojatatu.com \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.