From: Andrew Lunn <andrew@lunn.ch>
To: Egil Hjelmeland <privat@egil-hjelmeland.no>
Cc: vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@pengutronix.de
Subject: Re: [PATCH net-next 2/2] net: dsa: lan9303: Simplify lan9303_xxx_packet_processing() usage
Date: Mon, 31 Jul 2017 16:47:00 +0200 [thread overview]
Message-ID: <20170731144700.GG24562@lunn.ch> (raw)
In-Reply-To: <83b3fb27-97dd-a9ea-e0db-017d616f93fe@egil-hjelmeland.no>
> >Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> >
> > Andrew
> >
>
> Hi Andrew
>
> This time I took the extra effort to split my original patch...
>
> Your lan9303_write_switch_port suggestion (in previous reply) is fine.
> And I can improve the coverletter.
>
> So I will do a v2 of the patch. But what is your advice:
> Should I squash the patch?
I already gave my Reviewed-by:, meaning i don't really care. Merged or
squashed is a minor point in this case.
Andrew
next prev parent reply other threads:[~2017-07-31 14:47 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-31 11:33 [PATCH net-next 0/2] Refactor lan9303_xxx_packet_processing Egil Hjelmeland
2017-07-31 11:33 ` [PATCH net-next 1/2] net: dsa: lan9303: Refactor lan9303_xxx_packet_processing() Egil Hjelmeland
2017-07-31 13:36 ` Andrew Lunn
2017-07-31 11:33 ` [PATCH net-next 2/2] net: dsa: lan9303: Simplify lan9303_xxx_packet_processing() usage Egil Hjelmeland
2017-07-31 13:46 ` Andrew Lunn
2017-07-31 14:09 ` Egil Hjelmeland
2017-07-31 14:47 ` Andrew Lunn [this message]
2017-07-31 14:00 ` Vivien Didelot
2017-07-31 14:32 ` Egil Hjelmeland
2017-07-31 14:43 ` Vivien Didelot
2017-07-31 14:58 ` Egil Hjelmeland
2017-07-31 15:01 ` Vivien Didelot
2017-07-31 15:08 ` Egil Hjelmeland
2017-07-31 15:15 ` Vivien Didelot
2017-07-31 13:22 ` [PATCH net-next 0/2] Refactor lan9303_xxx_packet_processing Andrew Lunn
2017-07-31 13:32 ` Egil Hjelmeland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170731144700.GG24562@lunn.ch \
--to=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=privat@egil-hjelmeland.no \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.