From: Andreas Henriksson <andreas@fatal.se>
To: Karel Zak <kzak@redhat.com>
Cc: util-linux@vger.kernel.org, Sami Kerola <kerolasa@iki.fi>
Subject: Re: [PATCH] build: use --runstatedir instead of --localstatedir
Date: Mon, 31 Jul 2017 19:52:27 +0200 [thread overview]
Message-ID: <20170731175227.GA23732@fatal.se> (raw)
In-Reply-To: <20170731133156.2pk6qz7d6zmsevor@ws.net.home>
Hello Karel Zak,
On Mon, Jul 31, 2017 at 03:31:56PM +0200, Karel Zak wrote:
[...]
> It seems we need somehow to support autoconf < 2.70 where is no
> $runstatedir. So, I have modified the code to use fallback
>
> runstatedir='${localstatedir}/run'
>
> It also seems we need to check for unmodified $localstatedir rather
> than care about $prefix. So, I have improved the AS_CASE().
>
> Please, git-pull from master branch and retest it with new autoconf
> and your environment. Thanks.
Thanks for picking it up and improving it. I'm quite sure that
none of your changes will affect debian/debhelper builds.
(If I find something when I find time to test it properly I'll
report back.)
The important point for debhelpers point of view is that
./configure --runstatedir is used instead of
./configure --localstatedir (and the upstream AS_CASE/AS_IF
doesn't apply here since debhelper will pass both of those
configure flags explicitly.)
Please note clearly in the upcoming release notes than anyone
explicitly using the --localstatedir flag will need to move
over to --runstatedir (or accept/rely on util-linux defaults).
Regards,
Andreas Henriksson
prev parent reply other threads:[~2017-07-31 17:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-27 14:00 [PATCH] build: use --runstatedir instead of --localstatedir Andreas Henriksson
2017-07-31 13:31 ` Karel Zak
2017-07-31 17:52 ` Andreas Henriksson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170731175227.GA23732@fatal.se \
--to=andreas@fatal.se \
--cc=kerolasa@iki.fi \
--cc=kzak@redhat.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.