All of lore.kernel.org
 help / color / mirror / Atom feed
From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Boris Brezillon <boris.brezillon@free-electrons.com>,
	Richard Weinberger <richard@nod.at>,
	linux-mtd@lists.infradead.org
Cc: David Woodhouse <dwmw2@infradead.org>,
	Brian Norris <computersforpeace@gmail.com>,
	Marek Vasut <marek.vasut@gmail.com>,
	Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>,
	Alexander Dahl <ada@thorsis.com>,
	Nicolas Ferre <nicolas.ferre@atmel.com>,
	Alexandre Belloni <alexandre.belloni@free-electrons.com>
Subject: Re: [PATCH] mtd: nand: atmel: Fix EDO mode check
Date: Mon, 31 Jul 2017 18:28:13 +0200	[thread overview]
Message-ID: <20170731182813.3ec4d72e@bbrezillon> (raw)
In-Reply-To: <1501489941-7468-1-git-send-email-boris.brezillon@free-electrons.com>

On Mon, 31 Jul 2017 10:32:21 +0200
Boris Brezillon <boris.brezillon@free-electrons.com> wrote:

> EDO mode should be used when tRC is less than 30ns, but timings are
> expressed in picoseconds in the nand_sdr_timings struct.

Applied to nand/fixes.

> 
> Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> Fixes: f9ce2eddf176 ("mtd: nand: atmel: Add ->setup_data_interface() hooks")
> Reported-by: Alexander Dahl <ada@thorsis.com>
> ---
>  drivers/mtd/nand/atmel/nand-controller.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/nand/atmel/nand-controller.c b/drivers/mtd/nand/atmel/nand-controller.c
> index d922a88e407f..2c8baa0c2c4e 100644
> --- a/drivers/mtd/nand/atmel/nand-controller.c
> +++ b/drivers/mtd/nand/atmel/nand-controller.c
> @@ -1201,7 +1201,7 @@ static int atmel_smc_nand_prepare_smcconf(struct atmel_nand *nand,
>  	 * tRC < 30ns implies EDO mode. This controller does not support this
>  	 * mode.
>  	 */
> -	if (conf->timings.sdr.tRC_min < 30)
> +	if (conf->timings.sdr.tRC_min < 30000)
>  		return -ENOTSUPP;
>  
>  	atmel_smc_cs_conf_init(smcconf);

      parent reply	other threads:[~2017-07-31 16:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-31  8:32 [PATCH] mtd: nand: atmel: Fix EDO mode check Boris Brezillon
2017-07-31 11:54 ` Alexander Dahl
2017-07-31 16:28 ` Boris Brezillon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170731182813.3ec4d72e@bbrezillon \
    --to=boris.brezillon@free-electrons.com \
    --cc=ada@thorsis.com \
    --cc=alexandre.belloni@free-electrons.com \
    --cc=computersforpeace@gmail.com \
    --cc=cyrille.pitchen@wedev4u.fr \
    --cc=dwmw2@infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=marek.vasut@gmail.com \
    --cc=nicolas.ferre@atmel.com \
    --cc=richard@nod.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.