From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] qt5declarative: backport 'Fix alignment issue on ARMv7' patch to 5.9.1
Date: Mon, 31 Jul 2017 21:22:46 +0200 [thread overview]
Message-ID: <20170731212246.79362bcb@windsurf.home> (raw)
In-Reply-To: <20170731171359.32471-1-petar.koretic@qaap.io>
Hello,
On Mon, 31 Jul 2017 19:13:59 +0200, Petar Koretic wrote:
> diff --git a/package/qt5/qt5declarative/0003-Fix-alignment-issue-on-ARMv7.patch b/package/qt5/qt5declarative/0003-Fix-alignment-issue-on-ARMv7.patch
> new file mode 100644
> index 0000000000..da68826ccb
> --- /dev/null
> +++ b/package/qt5/qt5declarative/0003-Fix-alignment-issue-on-ARMv7.patch
> @@ -0,0 +1,34 @@
> +From 03c2661b1243cc529fc3d8cfa65073f1da420307 Mon Sep 17 00:00:00 2001
> +From: Simon Hausmann <simon.hausmann@qt.io>
> +Date: Thu, 22 Jun 2017 13:34:09 +0200
> +Subject: [PATCH] Fix alignment issue on ARMv7
> +
> +As analyzed in the bug report, it appears that we may get
> +QV4::CompiledData::Function pointers for writing that are not aligned
> +for the 64-bit fields at the beginning.
> +
> +[ChangeLog][QtQml] Fix crash due to misaligned data structures on ARMv7
> +
> +Task-number: QTBUG-61552
> +Change-Id: I6b2c166b725496150c8850475577628ccd811d65
> +Reviewed-by: Erik Verbruggen <erik.verbruggen@qt.io>
You should add your Signed-off-by here, and a link to the upstream bug
report or commit (I see you wrote the task number and change-id, but a
direct link is preferable).
Since anyway the patch was not entirely correct because it should be in
the 5.9.1/ subfolder, can you resend an updated version that takes into
account those small comments?
Thanks a lot!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-07-31 19:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-31 17:13 [Buildroot] [PATCH 1/1] qt5declarative: backport 'Fix alignment issue on ARMv7' patch to 5.9.1 Petar Koretic
2017-07-31 17:33 ` Thomas Petazzoni
2017-07-31 17:44 ` Petar Koretic
2017-07-31 17:48 ` Petar Koretic
2017-07-31 19:22 ` Thomas Petazzoni [this message]
2017-07-31 19:36 ` Petar Koretic
2017-07-31 19:43 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170731212246.79362bcb@windsurf.home \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.