All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ming Lei <ming.lei@redhat.com>
To: Jens Axboe <axboe@fb.com>,
	linux-block@vger.kernel.org,
	Christoph Hellwig <hch@infradead.org>
Cc: Ming Lei <minlei@redhat.com>
Subject: Re: [PATCH] blk-mq: don't leak preempt counter/q_usage_counter when allocating rq failed
Date: Tue, 1 Aug 2017 15:28:13 +0800	[thread overview]
Message-ID: <20170801072812.GA17297@ming.t460p> (raw)
In-Reply-To: <20170714084136.24850-1-ming.lei@redhat.com>

On Fri, Jul 14, 2017 at 04:41:36PM +0800, Ming Lei wrote:
> From: Ming Lei <minlei@redhat.com>
> 
> When blk_mq_get_request() failed, preempt counter isn't
> released, and blk_mq_make_request() doesn't release the counter
> too.
> 
> This patch fixes the issue, and makes sure that preempt counter
> is only held if rq is allocated successfully. The same policy is
> applied on .q_usage_counter too.

Hi Jens,

Given NOWAIT has been merged, could you consider this patch for
v4.13?

Thanks,
Ming

  reply	other threads:[~2017-08-01  7:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-14  8:41 [PATCH] blk-mq: don't leak preempt counter/q_usage_counter when allocating rq failed Ming Lei
2017-08-01  7:28 ` Ming Lei [this message]
2017-08-01 15:18 ` Jens Axboe
2017-08-02  0:03   ` Ming Lei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170801072812.GA17297@ming.t460p \
    --to=ming.lei@redhat.com \
    --cc=axboe@fb.com \
    --cc=hch@infradead.org \
    --cc=linux-block@vger.kernel.org \
    --cc=minlei@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.