From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olaf Hering <olaf@aepfle.de>
Subject: Re: [PATCH] vtpmmgr: make inline functions static
Date: Tue, 1 Aug 2017 17:13:21 +0200
Message-ID: <20170801151321.GC1646@aepfle.de>
References: <20170623173504.11785-1-olaf@aepfle.de>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8141344764234481437=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20170623173504.11785-1-olaf@aepfle.de>
List-Unsubscribe: <https://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <https://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xen.org
Sender: "Xen-devel" <xen-devel-bounces@lists.xen.org>
To: Daniel De Graaf <dgdegra@tycho.nsa.gov>, Quan Xu <quan.xu0@gmail.com>, Samuel Thibault <samuel.thibault@ens-lyon.org>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org


--===============8141344764234481437==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="hOcCNbCCxyk/YU74"
Content-Disposition: inline


--hOcCNbCCxyk/YU74
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Ping

On Fri, Jun 23, Olaf Hering wrote:

> gcc7 is more strict with functions marked as inline. They are not
> automatically inlined. Instead a function call is generated, but the
> actual code is not visible by the linker.
>=20
> Do a mechanical change and mark every 'inline' as 'static inline'. For
> simpler review the static goes into an extra line.
>=20
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
> ---
>  stubdom/vtpmmgr/marshal.h      | 76 ++++++++++++++++++++++++++++++++++++=
++++++
>  stubdom/vtpmmgr/tcg.h          | 14 ++++++++
>  stubdom/vtpmmgr/tpm2_marshal.h | 58 ++++++++++++++++++++++++++++++++
>  stubdom/vtpmmgr/tpmrsa.h       |  1 +
>  4 files changed, 149 insertions(+)
>=20
> diff --git a/stubdom/vtpmmgr/marshal.h b/stubdom/vtpmmgr/marshal.h
> index d826f19d89..dce19c6439 100644
> --- a/stubdom/vtpmmgr/marshal.h
> +++ b/stubdom/vtpmmgr/marshal.h
> @@ -47,16 +47,19 @@ typedef enum UnpackPtr {
>  	UNPACK_ALLOC
>  } UnpackPtr;
> =20
> +static
>  inline BYTE* pack_BYTE(BYTE* ptr, BYTE t) {

=2E..

--hOcCNbCCxyk/YU74
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iF0EARECAB0WIQSkRyP6Rn//f03pRUBdQqD6ppg2fgUCWYCajAAKCRBdQqD6ppg2
fhwNAJ0evFVvaR56FSQ2oY+IJtTiPwSnAACfeOA1shYhLjBChdgUoNeRsjxzOjo=
=TRWM
-----END PGP SIGNATURE-----

--hOcCNbCCxyk/YU74--


--===============8141344764234481437==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs
IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v
cmcveGVuLWRldmVsCg==

--===============8141344764234481437==--