From: Darren Hart <dvhart@infradead.org>
To: Andy Lutomirski <luto@kernel.org>
Cc: platform-driver-x86@vger.kernel.org, "Pali Rohár" <pali.rohar@gmail.com>
Subject: Re: [PATCH 1/3] platform/dell-wmi: Fix driver interface version query
Date: Tue, 1 Aug 2017 13:06:01 -0700 [thread overview]
Message-ID: <20170801200601.GD3110@fury> (raw)
In-Reply-To: <0cc9b015ed366f3fd104d2de707083c6ca2c2a5a.1501601667.git.luto@kernel.org>
On Tue, Aug 01, 2017 at 08:37:26AM -0700, Andy Lutomirski wrote:
> When I converted dell-wmi to the new bus infrastructure, I left the
> call to dell_wmi_check_descriptor_buffer() in dell_wmi_init(). This
> could cause two problems:
>
> - An error message when loading the driver on a system without
> dell-wmi. We'd try to read the event descriptor even if the WMI
> GUID wasn't there.
>
> - A possible race if dell-wmi was loaded manually before wmi was
> fully initialized.
>
> Fix it by moving the call to the probe function where it belongs.
>
> Fixes: bff589be59c5 ("platform/x86: dell-wmi: Convert to the WMI bus infrastructure")
> Signed-off-by: Andy Lutomirski <luto@kernel.org>
Queueing this one (1/3) to testing.
Pali, aside from the separate input event receiving discussion, do you have any
concerns with this patch? I'd like to get this to Linus this week for our 4.13-2
PR for this RC cycle.
--
Darren Hart
VMware Open Source Technology Center
next prev parent reply other threads:[~2017-08-01 20:06 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-01 15:37 [PATCH 0/3] Three WMI improvements Andy Lutomirski
2017-08-01 15:37 ` [PATCH 1/3] platform/dell-wmi: Fix driver interface version query Andy Lutomirski
2017-08-01 15:43 ` Pali Rohár
2017-08-01 18:08 ` Andy Lutomirski
2017-08-01 19:54 ` Darren Hart
2017-08-01 20:45 ` Pali Rohár
2017-08-01 20:59 ` Darren Hart
2017-08-01 21:16 ` Pali Rohár
2017-08-02 2:25 ` Andy Lutomirski
2017-08-02 2:54 ` Darren Hart
2017-08-01 19:52 ` Darren Hart
2017-08-01 20:06 ` Darren Hart [this message]
2017-08-01 20:36 ` Pali Rohár
2017-08-01 15:37 ` [PATCH 2/3] platform/dell-wmi: Update dell_wmi_check_descriptor_buffer() to new model Andy Lutomirski
2017-08-01 15:44 ` Pali Rohár
2017-08-19 0:14 ` Darren Hart
2017-08-01 15:37 ` [PATCH 3/3] platform/wmi: Expose the raw WDG data in sysfs Andy Lutomirski
2017-08-01 15:46 ` Pali Rohár
2017-08-01 18:29 ` Andy Lutomirski
2017-08-01 20:03 ` Darren Hart
2017-08-01 20:19 ` Andy Lutomirski
2017-08-01 20:40 ` Pali Rohár
2017-08-01 21:17 ` Darren Hart
2017-08-01 21:20 ` Rafael J. Wysocki
2017-08-01 21:36 ` Pali Rohár
2017-08-01 21:32 ` Rafael J. Wysocki
2017-08-01 22:06 ` Darren Hart
2017-08-01 21:31 ` Pali Rohár
2017-08-01 22:39 ` Darren Hart
2017-08-01 23:51 ` Andy Lutomirski
2017-08-02 2:22 ` Darren Hart
2017-08-02 7:49 ` Pali Rohár
2017-08-04 15:03 ` Andy Lutomirski
2017-08-06 21:36 ` Pali Rohár
2017-08-06 22:09 ` Andy Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170801200601.GD3110@fury \
--to=dvhart@infradead.org \
--cc=luto@kernel.org \
--cc=pali.rohar@gmail.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.