From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pali =?utf-8?B?Um9ow6Fy?= Subject: Re: [PATCH 1/3] platform/dell-wmi: Fix driver interface version query Date: Tue, 1 Aug 2017 22:36:37 +0200 Message-ID: <20170801203637.GG25574@pali> References: <0cc9b015ed366f3fd104d2de707083c6ca2c2a5a.1501601667.git.luto@kernel.org> <20170801200601.GD3110@fury> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from mail-wr0-f172.google.com ([209.85.128.172]:38572 "EHLO mail-wr0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752122AbdHAUgk (ORCPT ); Tue, 1 Aug 2017 16:36:40 -0400 Received: by mail-wr0-f172.google.com with SMTP id f21so11143434wrf.5 for ; Tue, 01 Aug 2017 13:36:40 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20170801200601.GD3110@fury> Sender: platform-driver-x86-owner@vger.kernel.org List-ID: To: Darren Hart Cc: Andy Lutomirski , platform-driver-x86@vger.kernel.org On Tuesday 01 August 2017 13:06:01 Darren Hart wrote: > On Tue, Aug 01, 2017 at 08:37:26AM -0700, Andy Lutomirski wrote: > > When I converted dell-wmi to the new bus infrastructure, I left the > > call to dell_wmi_check_descriptor_buffer() in dell_wmi_init(). This > > could cause two problems: > > > > - An error message when loading the driver on a system without > > dell-wmi. We'd try to read the event descriptor even if the WMI > > GUID wasn't there. > > > > - A possible race if dell-wmi was loaded manually before wmi was > > fully initialized. > > > > Fix it by moving the call to the probe function where it belongs. > > > > Fixes: bff589be59c5 ("platform/x86: dell-wmi: Convert to the WMI bus infrastructure") > > Signed-off-by: Andy Lutomirski > > Queueing this one (1/3) to testing. > > Pali, aside from the separate input event receiving discussion, do you have any > concerns with this patch? I'd like to get this to Linus this week for our 4.13-2 > PR for this RC cycle. It is ok, add my Reviewed-by: Pali Rohár -- Pali Rohár pali.rohar@gmail.com