From: Andrew Lunn <andrew@lunn.ch>
To: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@savoirfairelinux.com,
"David S. Miller" <davem@davemloft.net>,
Florian Fainelli <f.fainelli@gmail.com>,
John Crispin <john@phrozen.org>
Subject: Re: [PATCH net-next v2 01/11] net: dsa: PHY device is mandatory for EEE
Date: Tue, 1 Aug 2017 23:00:53 +0200 [thread overview]
Message-ID: <20170801210053.GN23157@lunn.ch> (raw)
In-Reply-To: <20170801203241.22294-2-vivien.didelot@savoirfairelinux.com>
On Tue, Aug 01, 2017 at 04:32:31PM -0400, Vivien Didelot wrote:
> The port's PHY and MAC are both implied in EEE. The current code does
> not call the PHY operations if the related device is NULL. Change that
> by returning -ENODEV if there's no PHY device attached to the interface.
>
> Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2017-08-01 21:00 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-01 20:32 [PATCH net-next v2 00/11] net: dsa: rework EEE support Vivien Didelot
2017-08-01 20:32 ` [PATCH net-next v2 01/11] net: dsa: PHY device is mandatory for EEE Vivien Didelot
2017-08-01 21:00 ` Andrew Lunn [this message]
2017-08-01 21:31 ` Florian Fainelli
2017-08-01 20:32 ` [PATCH net-next v2 02/11] net: dsa: qca8k: fix EEE init Vivien Didelot
2017-08-01 20:32 ` [PATCH net-next v2 03/11] net: dsa: qca8k: enable EEE once Vivien Didelot
2017-08-01 20:32 ` [PATCH net-next v2 04/11] net: dsa: qca8k: do not cache unneeded EEE fields Vivien Didelot
2017-08-01 20:32 ` [PATCH net-next v2 05/11] net: dsa: qca8k: empty qca8k_get_eee Vivien Didelot
2017-08-01 20:32 ` [PATCH net-next v2 06/11] net: dsa: bcm_sf2: remove unneeded supported flags Vivien Didelot
2017-08-01 21:29 ` Florian Fainelli
2017-08-01 20:32 ` [PATCH net-next v2 07/11] net: dsa: mv88e6xxx: call phy_init_eee Vivien Didelot
2017-08-01 21:03 ` Andrew Lunn
2017-08-01 20:32 ` [PATCH net-next v2 08/11] net: dsa: call phy_init_eee in DSA layer Vivien Didelot
2017-08-01 21:05 ` Andrew Lunn
2017-08-01 20:32 ` [PATCH net-next v2 09/11] net: dsa: remove PHY device argument from .set_eee Vivien Didelot
2017-08-01 21:06 ` Andrew Lunn
2017-08-01 20:32 ` [PATCH net-next v2 10/11] net: dsa: mv88e6xxx: remove EEE support Vivien Didelot
2017-08-01 21:07 ` Andrew Lunn
2017-08-01 20:32 ` [PATCH net-next v2 11/11] net: dsa: rename switch EEE ops Vivien Didelot
2017-08-01 21:08 ` Andrew Lunn
2017-08-02 3:09 ` [PATCH net-next v2 00/11] net: dsa: rework EEE support David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170801210053.GN23157@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=john@phrozen.org \
--cc=kernel@savoirfairelinux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.