From: Jeff Cody <jcody@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, kwolf@redhat.com, famz@redhat.com,
qemu-block@nongnu.org, mreitz@redhat.com, stefanha@redhat.com,
jsnow@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 for-2.11 3/3] qemu-iotests: add option to save temp files on error
Date: Tue, 1 Aug 2017 17:42:06 -0400 [thread overview]
Message-ID: <20170801214206.GA1525@localhost.localdomain> (raw)
In-Reply-To: <871sovztie.fsf@dusky.pond.sub.org>
On Tue, Aug 01, 2017 at 08:34:01AM +0200, Markus Armbruster wrote:
> Jeff Cody <jcody@redhat.com> writes:
>
> > Now that ./check takes care of cleaning up after each tests, it
> > can also selectively not clean up. Add option to leave all output from
> > tests intact if that test encountered an error.
> >
> > Note: this currently only works for bash tests, as the python tests
> > still clean up after themselves manually.
>
> Should we add a TODO comment for that?
>
Couldn't hurt!
> Much appreciated work, by the way. You might want to mention in one of
> your commit messages that this is also a step towards running iotests in
> parallel.
>
Thanks. I'll go ahead and spin a v3 to clean up commit messages and add a
TODO, since 2.11 won't open for a while.
> Another step towards sanity would be making $TEST_DIR instead of
> $source_iotests the current working directory for running tests.
Yep!
prev parent reply other threads:[~2017-08-01 21:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-31 13:47 [Qemu-devel] [PATCH v2 for-2.11 0/3] qemu-iotests: place output in unique dir Jeff Cody
2017-07-31 13:47 ` [Qemu-devel] [PATCH v2 for-2.11 1/3] qemu-iotests: set TEST_DIR to a unique dir for each test Jeff Cody
2017-07-31 14:44 ` Eric Blake
2017-07-31 15:07 ` Jeff Cody
2017-07-31 13:47 ` [Qemu-devel] [PATCH v2 for-2.11 2/3] qemu-iotests: remove file cleanup from bash tests Jeff Cody
2017-07-31 14:53 ` Eric Blake
2017-07-31 13:47 ` [Qemu-devel] [PATCH v2 for-2.11 3/3] qemu-iotests: add option to save temp files on error Jeff Cody
2017-08-01 6:34 ` Markus Armbruster
2017-08-01 21:42 ` Jeff Cody [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170801214206.GA1525@localhost.localdomain \
--to=jcody@redhat.com \
--cc=armbru@redhat.com \
--cc=famz@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.