All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ed Bartosh <ed.bartosh@linux.intel.com>
To: liu.ming50@gmail.com
Cc: Ming Liu <peter.x.liu@external.atlascopco.com>,
	openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/4] wic-image-minimal: drop WKS_FILE_DEPENDS definition
Date: Wed, 2 Aug 2017 11:38:37 +0300	[thread overview]
Message-ID: <20170802083837.GC2944@linux.intel.com> (raw)
In-Reply-To: <1501607630-30241-2-git-send-email-liu.ming50@gmail.com>

On Tue, Aug 01, 2017 at 07:13:47PM +0200, liu.ming50@gmail.com wrote:
> From: Ming Liu <peter.x.liu@external.atlascopco.com>
> 
> It's being set in image_types_wic.bbclass, not need to double set it
> here, furthermore, the dependencies are incomplete by missing
> e2fsprogs-native.
> 
> Signed-off-by: Ming Liu <peter.x.liu@external.atlascopco.com>
> ---
>  meta-selftest/recipes-test/images/wic-image-minimal.bb | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/meta-selftest/recipes-test/images/wic-image-minimal.bb b/meta-selftest/recipes-test/images/wic-image-minimal.bb
> index e1da203..af40d96 100644
> --- a/meta-selftest/recipes-test/images/wic-image-minimal.bb
> +++ b/meta-selftest/recipes-test/images/wic-image-minimal.bb
> @@ -6,8 +6,6 @@ IMAGE_INSTALL = "packagegroup-core-boot"
>  
>  IMAGE_FSTYPES = "wic"
>  
> -WKS_FILE_DEPENDS = "syslinux syslinux-native dosfstools-native mtools-native gptfdisk-native"
> -
>  LIC_FILES_CHKSUM = "file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
>  
>  IMAGE_ROOTFS_EXTRA_SPACE = "2000"

Please, consider adding e2fsprogs-native to the list instead of building
extra packages that are not going to be used.

--
Regards,
Ed


  reply	other threads:[~2017-08-02  9:01 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-01 17:13 [PATCH 0/4] Clean up some do_image_wic redundant code liu.ming50
2017-08-01 17:13 ` [PATCH 1/4] wic-image-minimal: drop WKS_FILE_DEPENDS definition liu.ming50
2017-08-02  8:38   ` Ed Bartosh [this message]
2017-08-01 17:13 ` [PATCH 2/4] image_types_wic.bbclass: deal with dependencies only with WKS_FILE_DEPENDS_DEFAULT liu.ming50
2017-08-02  8:26   ` Ed Bartosh
2017-08-02  8:56     ` Ming Liu
2017-08-01 17:13 ` [PATCH 3/4] qemux86.conf: drop do_image_wic task dependencies liu.ming50
2017-08-02  8:35   ` Ed Bartosh
2017-08-02  9:36     ` Ming Liu
2017-08-01 17:13 ` [PATCH 4/4] qemux86-64.conf: " liu.ming50

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170802083837.GC2944@linux.intel.com \
    --to=ed.bartosh@linux.intel.com \
    --cc=liu.ming50@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=peter.x.liu@external.atlascopco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.