All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Arend van Spriel <arend.vanspriel@broadcom.com>
Cc: linux-wireless@vger.kernel.org, Michael Skeffington <mike@astro.ai>
Subject: Re: [PATCH] mac80211: remove mic_fail_no_key label
Date: Wed, 2 Aug 2017 11:35:52 +0200	[thread overview]
Message-ID: <20170802093551.GA4777@redhat.com> (raw)
In-Reply-To: <598196F3.9070208@broadcom.com>

On Wed, Aug 02, 2017 at 11:10:11AM +0200, Arend van Spriel wrote:
> On 8/2/2017 11:04 AM, Stanislaw Gruszka wrote:
> >For historic reasons we have separate cases for mic_fail and
> >mic_fail_no_key. But with current code we can merge those cases,
> >as we already have NULL key check since:
> >
> >commit a66b98db570a638afd909459e1e6bfa272344bd3
> >Author: Arik Nemtsov <arik@wizery.com>
> >Date:   Thu Jun 23 00:00:24 2011 +0300
> >
> >     mac80211: fix rx->key NULL dereference during mic failure
> 
> Maybe better to use:
> ... since commit a66b98db570a ("mac80211: fix rx->key NULL
> dereference during mic failure").
> 
> as it is the preferred method to reference git commits.

Is easier for me to just copy-paste commit in form the git log/show
command provides, so I use that form. Is there tool or git log/show
option to get commit log in the preferred form, so I do not have to
change it manually?

Thanks
Stanislaw

  reply	other threads:[~2017-08-02  9:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-02  9:04 [PATCH] mac80211: remove mic_fail_no_key label Stanislaw Gruszka
2017-08-02  9:10 ` Arend van Spriel
2017-08-02  9:35   ` Stanislaw Gruszka [this message]
2017-08-02 10:07     ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170802093551.GA4777@redhat.com \
    --to=sgruszka@redhat.com \
    --cc=arend.vanspriel@broadcom.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mike@astro.ai \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.