From: Pavel Machek <pavel@ucw.cz>
To: Vadim Pasternak <vadimp@mellanox.com>
Cc: "j.anaszewski@samsung.com" <j.anaszewski@samsung.com>,
"rpurdie@rpsys.net" <rpurdie@rpsys.net>,
"linux-leds@vger.kernel.org" <linux-leds@vger.kernel.org>,
"lee.jones@linaro.org" <lee.jones@linaro.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"jiri@resnulli.us" <jiri@resnulli.us>,
"=jacek.anaszewski@gmail.com" <=jacek.anaszewski@gmail.com>
Subject: Re: [patch v3 1/1] leds: add driver for support Mellanox regmap LEDs for BMC
Date: Wed, 2 Aug 2017 13:11:36 +0200 [thread overview]
Message-ID: <20170802111136.GA1120@amd> (raw)
In-Reply-To: <AM4PR05MB33304B09E2DACFBA55BABD1FA2B00@AM4PR05MB3330.eurprd05.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 767 bytes --]
Hi!
> > =jacek.anaszewski@gmail.com
That email address looks funny.
> > > +/* Codes for LEDs. */
> > > +#define MLXREG_LED_OFFSET_HALF 0x01 /* Offset from solid:
> > 3Hz blink */
> > > +#define MLXREG_LED_OFFSET_FULL 0x02 /* Offset from solid:
> > 6Hz
> >
> > Can it do half brightness?
>
>
> This is about blinking frequency. Hardware support 6 hz blinking mode and 3hz blinking mode.
> If solid orange f.e. has bit mask 1100, setting 1101 or 1110 will blink orange with 3 or 6 KHz.
OFFSET_HALF -> OFFSET_BLINK_3HZ?
Otherwise looks good,
Acked-by: Pavel Machek <pavel@ucw.cz>
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2017-08-02 11:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-31 16:21 [patch v3 0/1] Introduce support for mlxreg LED driver Vadim Pasternak
2017-07-31 16:21 ` [patch v3 1/1] leds: add driver for support Mellanox regmap LEDs for BMC Vadim Pasternak
2017-08-02 8:38 ` Pavel Machek
2017-08-02 9:16 ` Vadim Pasternak
2017-08-02 11:11 ` Pavel Machek [this message]
2017-08-02 18:13 ` Jacek Anaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170802111136.GA1120@amd \
--to=pavel@ucw.cz \
--cc==jacek.anaszewski@gmail.com \
--cc=j.anaszewski@samsung.com \
--cc=jiri@resnulli.us \
--cc=lee.jones@linaro.org \
--cc=linux-leds@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=rpurdie@rpsys.net \
--cc=vadimp@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.