All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anatolij Gustschin <agust@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] imx6: fix SDn_CMD mux mode bitfield arguments
Date: Wed, 2 Aug 2017 12:24:27 +0200	[thread overview]
Message-ID: <20170802122427.559fc07c@crub> (raw)
In-Reply-To: <c8e4eecb-09e0-46a2-fb93-8c60ef05a2df@denx.de>

Hi Stefano,

On Wed, 2 Aug 2017 11:24:22 +0200
Stefano Babic sbabic at denx.de wrote:
...
> > -MX6_PAD_DECL(SD2_CMD__SD2_CMD,	0x0740, 0x0358, 16, 0x0000, 0, 0)
> > +MX6_PAD_DECL(SD2_CMD__SD2_CMD,		0x0740, 0x0358, 0, 0x0000, 0, 0)
...
> 
> The MUX mode is not changed, but 16 means that the SION bit is set. This
> forces the MUX to ALT0. I have no idea why the SION bit is set for SD,
> but we have already had some cases with ENET (and GIPOs require to set
> SION as well). In any case, if SION must be set, it should be not done
> with the value (16), but with the macro IOMUX_CONFIG_SION.

SD_CMD is bi-directional and SION setting seems to be intended here.
OK, I'll resubmit with IOMUX_CONFIG_SION to make it clear.

Thanks,

Anatolij

  reply	other threads:[~2017-08-02 10:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-01 13:14 [U-Boot] [PATCH] imx6: fix SDn_CMD mux mode bitfield arguments Anatolij Gustschin
2017-08-02  9:24 ` Stefano Babic
2017-08-02 10:24   ` Anatolij Gustschin [this message]
2017-08-02 13:56   ` [U-Boot] [PATCH] imx6: use SION macro in " Anatolij Gustschin
2017-08-02 13:58     ` Stefano Babic
2017-08-16  9:37     ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170802122427.559fc07c@crub \
    --to=agust@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.