From: Greg KH <greg@kroah.com>
To: Chris Brandt <Chris.Brandt@renesas.com>
Cc: "stable@vger.kernel.org" <stable@vger.kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Ulf Hansson <ulf.hansson@linaro.org>
Subject: Re: [PATCH] mmc: tmio-mmc: fix bad pointer math
Date: Wed, 2 Aug 2017 06:51:25 -0700 [thread overview]
Message-ID: <20170802135125.GA28578@kroah.com> (raw)
In-Reply-To: <SG2PR06MB11657DE4E2E311806145E8C88AB00@SG2PR06MB1165.apcprd06.prod.outlook.com>
On Wed, Aug 02, 2017 at 12:08:39PM +0000, Chris Brandt wrote:
> On Tuesday, August 01, 2017, Greg KH wrote:
> > On Tue, Aug 01, 2017 at 03:43:34PM -0500, Chris Brandt wrote:
> > > commit 9c284c41c0886f09e75c323a16278b6d353b0b4a upstream.
> > >
> > > The existing code gives an incorrect pointer value.
> > > The buffer pointer 'buf' was of type unsigned short *, and 'count' was a
> > > number in bytes. A cast of buf should have been used.
> > >
> > > However, instead of casting, just change the code to use u32 pointers.
> > >
> > > Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> > > Fixes: 8185e51f358a: ("mmc: tmio-mmc: add support for 32bit data port")
> > > Signed-off-by: Chris Brandt <chris.brandt@renesas.com>
> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > Acked-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> > > Cc: <stable@vger.kernel.org>
> > > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> > > ---
> > > drivers/mmc/host/tmio_mmc_pio.c | 19 +++++++++----------
> > > 1 file changed, 9 insertions(+), 10 deletions(-)
> >
> > What kernel tree(s) is this for?
> >
> > thanks,
> >
> > greg k-h
>
> I created this patch using the current 4.12.y branch. The code it fixes
> went in 4.10.
>
> The one thing I couldn't figure out by just looking at other stable
> commits was how you were supposed to know what tree I based the patch off so
> you had an idea where/how to apply it to. All I saw was that people
> just added 'commit xxxx upstream' to the commit log, but not what it was
> backported to.
>
> How was I supposed to give that info to you?
Just say below the --- line, "This patch is for kernel trees X, Y, and
Z" or some such thing.
thanks,
greg k-h
next prev parent reply other threads:[~2017-08-02 13:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-01 20:43 [PATCH] mmc: tmio-mmc: fix bad pointer math Chris Brandt
2017-08-01 21:03 ` Greg KH
2017-08-02 12:08 ` Chris Brandt
2017-08-02 13:51 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-07-11 16:29 Chris Brandt
2017-07-11 17:55 ` Geert Uytterhoeven
2017-07-11 19:37 ` Chris Brandt
2017-07-12 6:50 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170802135125.GA28578@kroah.com \
--to=greg@kroah.com \
--cc=Chris.Brandt@renesas.com \
--cc=geert+renesas@glider.be \
--cc=stable@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.