All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anatolij Gustschin <agust@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] imx-common: spl: return boot mode for asked MMC device in spl_boot_mode()
Date: Wed, 2 Aug 2017 17:32:10 +0200	[thread overview]
Message-ID: <20170802173210.6dce3eef@crub> (raw)
In-Reply-To: <ff21eecc-6fd6-f00d-3094-77fda01dc068@denx.de>

Hi Stefano,

On Wed, 2 Aug 2017 11:54:24 +0200
Stefano Babic sbabic at denx.de wrote:
...
> > +++ b/arch/arm/mach-imx/spl.c
> > @@ -84,7 +84,7 @@ u32 spl_boot_device(void)
> >  /* called from spl_mmc to see type of boot mode for storage (RAW or FAT) */
> >  u32 spl_boot_mode(const u32 boot_device)
> >  {
> > -	switch (spl_boot_device()) {
> > +	switch (boot_device) {
> >  	/* for MMC return either RAW or FAT mode */
> >  	case BOOT_DEVICE_MMC1:
> >  	case BOOT_DEVICE_MMC2:
> >   
> 
> Nevertheless it seems difficult to be consistent. Let's start with the
> case where a on-board device (SPI or eMMC) does not boot, and the way to
> save the board is to boot from an external board. And SPL on the onboard
> flash is damaged, but not u-boot.img. Anyway, we want that the board
> boots with its consistent status, that is with the pair SPL+u-boot.img.
> In the example I tracked, both from the SD card. This is consistent
> using spl_boot_device, because it does not try to boot from a different
> device as the one where SPL was loaded.

thanks for explanation, I'll have to find another way then, or
will maintain this patch out of tree.

--
Anatolij

      reply	other threads:[~2017-08-02 15:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-01 13:23 [U-Boot] [PATCH] imx-common: spl: return boot mode for asked MMC device in spl_boot_mode() Anatolij Gustschin
2017-08-02  9:54 ` Stefano Babic
2017-08-02 15:32   ` Anatolij Gustschin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170802173210.6dce3eef@crub \
    --to=agust@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.