From: Darren Hart <dvhart@infradead.org>
To: Shuah Khan <shuahkh@osg.samsung.com>
Cc: shuah@kernel.org, tglx@linutronix.de, mingo@redhat.com,
peterz@infradead.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH] selftests: futex: fix run_tests target
Date: Wed, 2 Aug 2017 17:52:22 -0700 [thread overview]
Message-ID: <20170803005222.GC27974@fury> (raw)
In-Reply-To: <20170802223142.20282-1-shuahkh@osg.samsung.com>
On Wed, Aug 02, 2017 at 04:31:42PM -0600, Shuah Khan wrote:
> make -C tools/testing/selftests/futex/ run_tests doesn't run the tests.
> Running run_tests target only when $(OUTPUT) is the $(PWD) is incorrect.
> When $(OUTPUT) is empty, run_tests will not run. Fix it.
>
> Fixes: a8ba798bc8ec ("selftests: enable O and KBUILD_OUTPUT")
> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
So this indeed addresses the problem you reported.
I'm curious about why this was changed like it was. I presume to avoid
some issues with relative paths, like the ./run.sh and the "cd
functional" within run.sh.... but I haven't been able to trigger that.
When you say $(OUTPUT) is empty - when does that occur? Because if it
was in fact "" then the change below would attempt to execute /run.sh
... which is surely not what we want.
> ---
> tools/testing/selftests/futex/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/futex/Makefile b/tools/testing/selftests/futex/Makefile
> index e2fbb890aef9..7c647f619d63 100644
> --- a/tools/testing/selftests/futex/Makefile
> +++ b/tools/testing/selftests/futex/Makefile
> @@ -14,7 +14,7 @@ all:
> done
>
> override define RUN_TESTS
> - @if [ `dirname $(OUTPUT)` = $(PWD) ]; then ./run.sh; fi
> + $(OUTPUT)/run.sh
> endef
>
> override define INSTALL_RULE
> --
> 2.11.0
>
>
--
Darren Hart
VMware Open Source Technology Center
next prev parent reply other threads:[~2017-08-03 0:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-02 22:31 [PATCH] selftests: futex: fix run_tests target Shuah Khan
2017-08-03 0:52 ` Darren Hart [this message]
2017-08-03 1:06 ` Shuah Khan
2017-08-04 16:40 ` Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170803005222.GC27974@fury \
--to=dvhart@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=shuah@kernel.org \
--cc=shuahkh@osg.samsung.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.