From: Kalle Valo <kvalo@codeaurora.org>
To: Sven Joachim <svenjoac@gmx.de>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
linux-wireless@vger.kernel.org, Ping-Ke Shih <pkshih@realtek.com>
Subject: Re: [v2] rtlwifi: Fix fallback firmware loading
Date: Thu, 3 Aug 2017 09:36:22 +0000 (UTC) [thread overview]
Message-ID: <20170803093623.101DC6037B@smtp.codeaurora.org> (raw)
In-Reply-To: <87d18gmvsq.fsf_-_@turtle.gmx.de>
Sven Joachim <svenjoac@gmx.de> wrote:
> Commit f70e4df2b384 ("rtlwifi: Add code to read new versions of
> firmware") added code to load an old firmware file if the new one is
> not available. Unfortunately that code is never reached because
> request_firmware_nowait() does not wait for the firmware to show up
> and returns 0 even if the file is not there.
>
> Use the existing fallback mechanism introduced by commit 62009b7f1279
> ("rtlwifi: rtl8192cu: Add new firmware") instead.
>
> Fixes: f70e4df2b384 ("rtlwifi: Add code to read new versions of firmware")
> Cc: stable@vger.kernel.org
> Signed-off-by: Sven Joachim <svenjoac@gmx.de>
Patch applied to wireless-drivers-next.git, thanks.
1d9b168d8ea9 rtlwifi: Fix fallback firmware loading
--
https://patchwork.kernel.org/patch/9872413/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2017-08-03 9:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-28 11:14 Loading fallback firmware in rtl8723be and rtl8821ae fails Sven Joachim
2017-07-29 9:21 ` [PATCH] rtlwifi: Fix fallback firmware loading Sven Joachim
2017-07-30 23:57 ` Larry Finger
2017-07-31 16:10 ` [PATCH v2] " Sven Joachim
2017-08-03 9:36 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170803093623.101DC6037B@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=Larry.Finger@lwfinger.net \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
--cc=svenjoac@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.