All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Egil Hjelmeland <privat@egil-hjelmeland.no>
Cc: vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel@pengutronix.de
Subject: Re: [PATCH v3 net-next 4/5] net: dsa: lan9303: Rename lan9303_xxx_packet_processing()
Date: Thu, 3 Aug 2017 15:28:49 +0200	[thread overview]
Message-ID: <20170803132849.GD15018@lunn.ch> (raw)
In-Reply-To: <20170803094507.3439-5-privat@egil-hjelmeland.no>

On Thu, Aug 03, 2017 at 11:45:06AM +0200, Egil Hjelmeland wrote:
> The lan9303_enable_packet_processing, lan9303_disable_packet_processing
> functions operate on port, so the names should reflect that.
> And to align with lan9303_disable_processing(), rename:
> 
> lan9303_enable_packet_processing -> lan9303_enable_processing_port
> lan9303_disable_packet_processing -> lan9303_disable_processing_port
> 
> Signed-off-by: Egil Hjelmeland <privat@egil-hjelmeland.no>


Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

  reply	other threads:[~2017-08-03 13:28 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-03  9:45 [PATCH v3 net-next 0/5] Refactor lan9303_xxx_packet_processing Egil Hjelmeland
2017-08-03  9:45 ` [PATCH v3 net-next 1/5] net: dsa: lan9303: Change lan9303_xxx_packet_processing() port param Egil Hjelmeland
2017-08-03 13:27   ` Andrew Lunn
2017-08-03 18:08   ` Florian Fainelli
2017-08-03  9:45 ` [PATCH v3 net-next 2/5] net: dsa: lan9303: define LAN9303_NUM_PORTS 3 Egil Hjelmeland
2017-08-03 13:27   ` Andrew Lunn
2017-08-03 18:01   ` Florian Fainelli
2017-08-03  9:45 ` [PATCH v3 net-next 3/5] net: dsa: lan9303: Simplify lan9303_xxx_packet_processing() usage Egil Hjelmeland
2017-08-03 13:28   ` Andrew Lunn
2017-08-03 18:06   ` Florian Fainelli
2017-08-03 20:16     ` Egil Hjelmeland
2017-08-03  9:45 ` [PATCH v3 net-next 4/5] net: dsa: lan9303: Rename lan9303_xxx_packet_processing() Egil Hjelmeland
2017-08-03 13:28   ` Andrew Lunn [this message]
2017-08-03 18:08   ` Florian Fainelli
2017-08-03  9:45 ` [PATCH v3 net-next 5/5] net: dsa: lan9303: refactor lan9303_get_ethtool_stats Egil Hjelmeland
2017-08-03 13:30   ` Andrew Lunn
2017-08-03 18:04   ` Florian Fainelli
2017-08-03 20:26     ` Egil Hjelmeland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170803132849.GD15018@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=f.fainelli@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=privat@egil-hjelmeland.no \
    --cc=vivien.didelot@savoirfairelinux.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.