All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] cve/cve-2017-2671.c: check if socket() supports IPPROTO_ICMP
Date: Thu, 3 Aug 2017 17:52:29 +0200	[thread overview]
Message-ID: <20170803155229.GD15519@rei> (raw)
In-Reply-To: <1501751564-8002-1-git-send-email-yangx.jy@cn.fujitsu.com>

Hi!
> socket() does not support IPPROTO_ICMP, and the ping_group_range file
> does not exist in older kernels(e.g. RHEL5.11GA).  these supports are
> introduced by:
> 'c319b4d("net: ipv4: add IPPROTO_ICMP socket kind")'

Hm, the question is if there is a system that supports IPPROTO_ICMP
and where the ping_group_range file is missing. Does that even happen?

If not we should simplify this by exitting (tst_brk()) with TCONF if the
ping_group_range is missing instead of doing that later on
EPROTONOSUPPORT.

-- 
Cyril Hrubis
chrubis@suse.cz

  reply	other threads:[~2017-08-03 15:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-03  9:12 [LTP] [PATCH] cve/cve-2017-2671.c: check if socket() supports IPPROTO_ICMP Xiao Yang
2017-08-03 15:52 ` Cyril Hrubis [this message]
2017-08-04  1:00   ` Xiao Yang
2017-08-04  1:21   ` [LTP] [PATCH v2] " Xiao Yang
2017-08-04 10:33     ` Cyril Hrubis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170803155229.GD15519@rei \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.