From: Stephen Hemminger <stephen@networkplumber.org>
To: Florian Lehner <dev@der-flo.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH v4] ss: Enclose IPv6 address in brackets
Date: Thu, 3 Aug 2017 15:54:21 -0700 [thread overview]
Message-ID: <20170803155421.482fd158@xeon-e3> (raw)
In-Reply-To: <821a72fb-3758-8a44-2b1e-727a73208e14@der-flo.net>
On Tue, 1 Aug 2017 18:54:33 +0200
Florian Lehner <dev@der-flo.net> wrote:
> - if (a->family == AF_INET) {
> - if (a->data[0] == 0) {
> + if (a->data[0] == 0) {
> buf[0] = '*';
> buf[1] = 0;
This won't work right with IPv6 you need to look at the whole address being 0
not just a->data[0]
next prev parent reply other threads:[~2017-08-03 22:54 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-29 12:29 [PATCH] ss: Enclose IPv6 address in brackets Florian Lehner
2017-07-29 15:26 ` Stephen Hemminger
2017-07-31 10:30 ` Phil Sutter
2017-07-31 16:27 ` Stephen Hemminger
2017-07-31 16:43 ` Phil Sutter
2017-07-31 18:17 ` Florian Lehner
2017-07-31 19:50 ` [PATCH v2] " Florian Lehner
2017-07-31 20:27 ` Phil Sutter
2017-08-01 10:05 ` [PATCH v3] " Florian Lehner
2017-08-01 14:11 ` Phil Sutter
2017-08-01 16:07 ` Florian Lehner
2017-08-01 11:11 ` [PATCH] " David Laight
2017-08-01 14:41 ` Stephen Hemminger
2017-08-01 16:54 ` [PATCH v4] " Florian Lehner
2017-08-03 22:54 ` Stephen Hemminger [this message]
2017-08-04 18:02 ` [PATCH v5] " Florian Lehner
2017-08-04 19:05 ` Stephen Hemminger
2017-08-04 20:46 ` Eric Dumazet
2017-08-04 22:13 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170803155421.482fd158@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=dev@der-flo.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.