All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cornelia Huck <cohuck@redhat.com>
To: qemu-devel@nongnu.org
Cc: borntraeger@de.ibm.com, agraf@suse.de, thuth@redhat.com,
	david@redhat.com, pmorel@linux.vnet.ibm.com,
	zyimin@linux.vnet.ibm.com, Cornelia Huck <cohuck@redhat.com>
Subject: [Qemu-devel] [PATCH v4 8/9] s390x/kvm: msi route fixup for non-pci
Date: Fri,  4 Aug 2017 13:29:45 +0200	[thread overview]
Message-ID: <20170804112946.5247-9-cohuck@redhat.com> (raw)
In-Reply-To: <20170804112946.5247-1-cohuck@redhat.com>

If we don't provide pci, we cannot have a pci device for which we
have to translate to adapter routes: just return -ENODEV.

Signed-off-by: Cornelia Huck <cohuck@redhat.com>
---
 target/s390x/kvm.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/target/s390x/kvm.c b/target/s390x/kvm.c
index 9de165d8b1..d8db1cbf6e 100644
--- a/target/s390x/kvm.c
+++ b/target/s390x/kvm.c
@@ -2424,6 +2424,12 @@ int kvm_arch_fixup_msi_route(struct kvm_irq_routing_entry *route,
     uint32_t idx = data >> ZPCI_MSI_VEC_BITS;
     uint32_t vec = data & ZPCI_MSI_VEC_MASK;
 
+    if (!s390_has_feat(S390_FEAT_ZPCI)) {
+        /* How can we get here without pci enabled? */
+        g_assert(false);
+        return -ENODEV;
+    }
+
     pbdev = s390_pci_find_dev_by_idx(s390_get_phb(), idx);
     if (!pbdev) {
         DPRINTF("add_msi_route no dev\n");
-- 
2.13.3

  parent reply	other threads:[~2017-08-04 14:04 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-04 11:29 [Qemu-devel] [PATCH v4 0/9] s390x: zPCI detangling Cornelia Huck
2017-08-04 11:29 ` [Qemu-devel] [PATCH v4 1/9] kvm: remove hard dependency on pci Cornelia Huck
2017-08-04 11:29 ` [Qemu-devel] [PATCH v4 2/9] s390x/pci: add stubs Cornelia Huck
2017-08-04 11:29 ` [Qemu-devel] [PATCH v4 3/9] s390x: chsc nt2 events are pci-only Cornelia Huck
2017-08-04 11:29 ` [Qemu-devel] [PATCH v4 4/9] s390x/pci: do not advertise pci on non-pci builds Cornelia Huck
2017-08-04 13:21   ` David Hildenbrand
2017-08-04 11:29 ` [Qemu-devel] [PATCH v4 5/9] s390x/ccw: create s390 phb conditionally Cornelia Huck
2017-08-04 13:20   ` David Hildenbrand
2017-08-07 10:00     ` Cornelia Huck
2017-08-07 10:21       ` David Hildenbrand
2017-08-07 11:11         ` Cornelia Huck
2017-08-04 11:29 ` [Qemu-devel] [PATCH v4 6/9] s390x/sclp: properly guard pci-specific functions Cornelia Huck
2017-08-04 11:29 ` [Qemu-devel] [PATCH v4 7/9] s390x/pci: fence off instructions for non-pci Cornelia Huck
2017-08-04 13:17   ` David Hildenbrand
2017-08-07  9:52     ` Cornelia Huck
2017-08-07 14:17       ` David Hildenbrand
2017-08-04 11:29 ` Cornelia Huck [this message]
2017-08-04 13:18   ` [Qemu-devel] [PATCH v4 8/9] s390x/kvm: msi route fixup " David Hildenbrand
2017-08-07  9:54     ` Cornelia Huck
2017-08-04 11:29 ` [Qemu-devel] [PATCH v4 9/9] s390x: refine pci dependencies Cornelia Huck
2017-08-04 13:25   ` David Hildenbrand
2017-08-04 14:59 ` [Qemu-devel] [PATCH v4 0/9] s390x: zPCI detangling Cornelia Huck
2017-08-08  9:15   ` Cornelia Huck
2017-08-08  9:29     ` Thomas Huth
2017-08-08  9:46       ` Cornelia Huck
2017-08-08 10:42         ` Thomas Huth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170804112946.5247-9-cohuck@redhat.com \
    --to=cohuck@redhat.com \
    --cc=agraf@suse.de \
    --cc=borntraeger@de.ibm.com \
    --cc=david@redhat.com \
    --cc=pmorel@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    --cc=zyimin@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.