From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH] scsi: sg: Prevent potential double frees in sg driver Date: Sat, 5 Aug 2017 13:37:47 +0200 Message-ID: <20170805113747.GE16313@lst.de> References: <20170803190248.51537-1-ndesaulniers@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20170803190248.51537-1-ndesaulniers@google.com> Sender: linux-kernel-owner@vger.kernel.org To: Nick Desaulniers Cc: hare@suse.de, jthumshirn@suse.de, hch@lst.de, salyzyn@google.com, gregkh@linuxfoundation.org, Robb Glasser , Doug Gilbert , "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-scsi@vger.kernel.org This looks correct and safe to me, but I wonder if anyone relies on multi-threaded /dev/sg write usage, which would be completely serialized with this.