Re: [PATCH v3] HID: apple: Use country code to detect ISO keyboards

[Lukas Wunner <lukas@wunner.de>]

On Tue, Jun 20, 2017 at 08:00:53PM +0200, Bastien Nocera wrote:
> On Tue, 2017-06-20 at 11:18 -0600, Alex Henrie wrote:
> > > Does this patch mean we can assume that the hardware model is
> > > "pc105"
> > > instead of various flavours of "mac" in xkeyboard-config's X
> > > keymaps?
> > 
> > I use the pc105 keymap with my Macbook 12,1 and don't have any
> > problems, so for me at least, the answer is yes.
> 
> Yay! This was a long-standing "wouldn't it be nice" bug from when I
> still used a MacBook Air on a daily basis:
> https://bugzilla.gnome.org/show_bug.cgi?id=650379
> https://bugzilla.gnome.org/show_bug.cgi?id=650772
> https://bugs.freedesktop.org/show_bug.cgi?id=37446
> 
> > > Does this also work with older Apple USB keyboards? (Most of the
> > > older
> > > ones triggered the "press those 2 buttons so we can figure out
> > > which
> > > type of keyboard you have", under macOS)
> > 
> > The oldest Apple ISO keyboard I could find information on is the
> > "Apple Geyser3 ISO", USB ID 05ac:0218. In 2008 an Arch Linux forum
> > user posted the output of `lsusb -v` which shows that bCountryCode is
> > set to 13 on this keyboard:
> > https://bbs.archlinux.org/viewtopic.php?pid=328653#p328653
> > 
> > Do you have any old Apple ISO keyboards? If you find one that doesn't
> > fill in bCountryCode, we could bring back the APPLE_ISO_KEYBOARD
> > quirk
> > for that model.
> 
> I have a 2011 MacBook Pro on which I could test this (I honestly don't
> remember the cut-off for ADB/BIOS keyboards to USB), but no external
> ones.
> 
> I also wonder whether that data is exported for Bluetooth and the newer
> I2C keyboards.

Good point, the folks working on the driver for SPI (not I2C) keyboards
have recently *added* a command line option to enable/disable the ISO
layout.  Ideally it should likewise be autosensed so I've opened this
issue:

https://github.com/cb22/macbook12-spi-driver/issues/44

Adding some of the SPI driver devs to cc.

Thanks,

Lukas