From: "Pali Rohár" <pali.rohar@gmail.com>
To: Richard Weinberger <richard@nod.at>
Cc: David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Boris Brezillon <boris.brezillon@free-electrons.com>,
Marek Vasut <marek.vasut@gmail.com>,
Artem Bityutskiy <dedekind1@gmail.com>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 5/5] ubi: Allow to use read-only UBI volume with not enough PEBs
Date: Sun, 6 Aug 2017 12:30:02 +0200 [thread overview]
Message-ID: <201708061230.02997@pali> (raw)
In-Reply-To: <0527d020-95aa-80e5-978c-fa9b6761a273@nod.at>
[-- Attachment #1: Type: Text/Plain, Size: 1190 bytes --]
On Sunday 06 August 2017 11:43:25 Richard Weinberger wrote:
> Pali,
>
> Am 25.07.2017 um 16:27 schrieb Pali Rohár:
> >> I fear this is not correct, it will disable a legit self-check of
> >> UBI volumes. If the read-only volume is corrupted/truncated and
> >> you miss PEBs, this check will no longer
> >> trigger.
> >>
> >> Especially when dealing with nanddumps, truncation is a common
> >> problem.
> >
> > Any idea how to fix it? Or how to handle read-only images which are
> > marked for auto-resize?
>
> I'd vote for rejecting images that have auto-resize set when the MTD
> is read-only. In fact, using UBI on top of a read-only MTD is very
> uncommon and not recommended (for NAND). The auto-resize flag should
> be also only set when you just have created it using mkfs.ubifs. Why
> would you inspect such an image with the kernel UBIFS unless you're
> hunting down a bug in mkfs.ubifs?
>
> Thanks,
> //richard
E.g. because when I get UBIFS image and I want to unpack it.
IMO UBIFS image which have auto-resize set is also valid UBIFS image and
kernel should be able to read it too, even in R/O mode.
--
Pali Rohár
pali.rohar@gmail.com
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2017-08-06 10:30 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-02 15:43 [PATCH 0/5] Extends block2mtd and ubi drivers Pali Rohár
2017-06-02 15:43 ` [PATCH 1/5] mtd: block2mtd: Check for valid user supplied erase size Pali Rohár
2017-07-21 19:45 ` Richard Weinberger
2017-06-02 15:43 ` [PATCH 2/5] mtd: block2mtd: Add support for specifying MTD write size and subpage shift Pali Rohár
2017-06-02 16:13 ` Richard Weinberger
2017-06-05 11:21 ` Pali Rohár
2017-06-05 11:23 ` Richard Weinberger
2017-06-05 11:25 ` Pali Rohár
2017-06-05 11:27 ` Richard Weinberger
2017-06-07 8:46 ` Pali Rohár
2017-06-18 10:06 ` Pavel Machek
2017-06-18 10:11 ` Richard Weinberger
2017-07-17 12:34 ` Pali Rohár
2017-06-02 15:43 ` [PATCH 3/5] mtd: block2mtd: Fallback to read-only mode Pali Rohár
2017-07-21 19:53 ` Richard Weinberger
2017-07-25 14:28 ` Pali Rohár
2017-06-02 15:43 ` [PATCH 4/5] mtd: block2mtd: Add support for deleting block2mtd mapping Pali Rohár
2017-07-21 19:56 ` Richard Weinberger
2017-07-25 14:24 ` Pali Rohár
2017-08-06 9:39 ` Richard Weinberger
2017-06-02 15:43 ` [PATCH 5/5] ubi: Allow to use read-only UBI volume with not enough PEBs Pali Rohár
2017-07-21 20:12 ` Richard Weinberger
2017-07-25 14:27 ` Pali Rohár
2017-08-06 9:43 ` Richard Weinberger
2017-08-06 10:30 ` Pali Rohár [this message]
2017-06-02 16:17 ` [PATCH 0/5] Extends block2mtd and ubi drivers Richard Weinberger
2017-06-05 11:18 ` Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201708061230.02997@pali \
--to=pali.rohar@gmail.com \
--cc=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.