From: Eric Wong <e@80x24.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Urs Thuermann <urs@isnogud.escape.de>
Subject: Re: [PATCH] git svn fetch: Create correct commit timestamp when using --localtime
Date: Tue, 8 Aug 2017 02:42:39 +0000 [thread overview]
Message-ID: <20170808024239.GA2915@starla> (raw)
In-Reply-To: <xmqqlgmvni8x.fsf@gitster.mtv.corp.google.com>
Junio C Hamano <gitster@pobox.com> wrote:
> Urs Thuermann <urs@isnogud.escape.de> writes:
>
> > In parse_svn_date() prepend the correct UTC offset to the timestamp
> > returned. This is the offset in effect at the commit time instead of
> > the offset in effect at calling time.
> >
> > Signed-off-by: Urs Thuermann <urs@isnogud.escape.de>
> > ---
> > perl/Git/SVN.pm | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Thanks; sounds sensible.
>
> Eric?
Yep, seems alright. Can you apply directly?
Been a bit preoccupied as of late. Thanks.
next prev parent reply other threads:[~2017-08-08 2:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-05 0:12 [PATCH] git svn fetch: Create correct commit timestamp when using --localtime Urs Thuermann
2017-08-07 22:08 ` Junio C Hamano
2017-08-08 2:42 ` Eric Wong [this message]
2017-08-02 14:36 ` git svn fetch --localtime produces wrong commit times Urs Thuermann
2017-08-02 21:34 ` Urs Thuermann
2017-08-08 16:57 ` [PATCH] git svn fetch: Create correct commit timestamp when using --localtime Junio C Hamano
2017-08-08 18:56 ` Urs Thuermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170808024239.GA2915@starla \
--to=e@80x24.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=urs@isnogud.escape.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.