Re: [patch v2 1/2] mfd: Add Mellanox regmap core driver

[Pavel Machek <pavel-+ZI9xUNit7I@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1212 bytes --]

Hi!

> > Why don't you extend the support you already provide in drivers/platform?
> > This seems like a logical place for an all encompassing device which cannot be
> > split out to individual subsystems.
> 
> There is a problem to extend for that the existing driver
> drivers/platform/x86/mlxcpld-hotplug.c.
> It has been provided for x86 arch and I am planning to extend it with ACPI
> support.
> 
> But in mlxreg-core I am using DTS, which is not supported for x86.
> Here I am using the next functions for probing and removing hotplug
> entities:
> static void mlxreg_core_dev_enable(struct device_node *np)
> {
> 	/* Enable and create device. */
> 	of_update_property(np, &mlxreg_core_device_en);
> }
> 
> static void mlxreg_core_dev_disable(struct device_node *np)
> {
> 	/* Disable and unregister platform device. */
> 	of_update_property(np, &mlxreg_core_device_dis);
> 	of_node_clear_flag(np, OF_POPULATED);
> }
> 
> And such code can't be placed under drivers/platform/x86/.

So aim for drivers/platform/mlx ...?

									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]