diff for duplicates of <20170808080821.GA31730@bbox> diff --git a/a/1.txt b/N1/1.txt index 876086e..874b028 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -51,32 +51,3 @@ https://marc.info/?l=linux-mm&m=150156699114088&w=2 Anyway, thanks for the pointing out. xiaolong.ye, could you retest with this fix? - -From 83012114c9cd9304f0d55d899bb4b9329d0e22ac Mon Sep 17 00:00:00 2001 -From: Minchan Kim <minchan@kernel.org> -Date: Tue, 8 Aug 2017 17:05:19 +0900 -Subject: [PATCH] mm: decrease tlb flush pending count in tlb_finish_mmu - -The tlb pending count increased by tlb_gather_mmu should be decreased -at tlb_finish_mmu. Otherwise, A lot of TLB happens which makes -performance regression. - -Signed-off-by: Minchan Kim <minchan@kernel.org> ---- - mm/memory.c | 1 + - 1 file changed, 1 insertion(+) - -diff --git a/mm/memory.c b/mm/memory.c -index 34b1fcb829e4..ad2617552f55 100644 ---- a/mm/memory.c -+++ b/mm/memory.c -@@ -423,6 +423,7 @@ void tlb_finish_mmu(struct mmu_gather *tlb, - bool force = mm_tlb_flush_nested(tlb->mm); - - arch_tlb_finish_mmu(tlb, start, end, force); -+ dec_tlb_flush_pending(tlb->mm); - } - - /* --- -2.7.4 diff --git a/a/content_digest b/N1/content_digest index 18881cd..054ab96 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -75,35 +75,6 @@ "https://marc.info/?l=linux-mm&m=150156699114088&w=2\n" "\n" "Anyway, thanks for the pointing out.\n" - "xiaolong.ye, could you retest with this fix?\n" - "\n" - "From 83012114c9cd9304f0d55d899bb4b9329d0e22ac Mon Sep 17 00:00:00 2001\n" - "From: Minchan Kim <minchan@kernel.org>\n" - "Date: Tue, 8 Aug 2017 17:05:19 +0900\n" - "Subject: [PATCH] mm: decrease tlb flush pending count in tlb_finish_mmu\n" - "\n" - "The tlb pending count increased by tlb_gather_mmu should be decreased\n" - "at tlb_finish_mmu. Otherwise, A lot of TLB happens which makes\n" - "performance regression.\n" - "\n" - "Signed-off-by: Minchan Kim <minchan@kernel.org>\n" - "---\n" - " mm/memory.c | 1 +\n" - " 1 file changed, 1 insertion(+)\n" - "\n" - "diff --git a/mm/memory.c b/mm/memory.c\n" - "index 34b1fcb829e4..ad2617552f55 100644\n" - "--- a/mm/memory.c\n" - "+++ b/mm/memory.c\n" - "@@ -423,6 +423,7 @@ void tlb_finish_mmu(struct mmu_gather *tlb,\n" - " \tbool force = mm_tlb_flush_nested(tlb->mm);\n" - " \n" - " \tarch_tlb_finish_mmu(tlb, start, end, force);\n" - "+\tdec_tlb_flush_pending(tlb->mm);\n" - " }\n" - " \n" - " /*\n" - "-- \n" - 2.7.4 + xiaolong.ye, could you retest with this fix? -cd04ce2ddf2a697084b70840ca75ff7e63949f856d5b7ad5b15acd05c55a37bc +cef16a1b41f2e1be39eadc3adf9e80490873a89c48e90c9df1405832aff6f6b3
diff --git a/a/1.txt b/N2/1.txt index 876086e..10769e2 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -52,7 +52,7 @@ https://marc.info/?l=linux-mm&m=150156699114088&w=2 Anyway, thanks for the pointing out. xiaolong.ye, could you retest with this fix? -From 83012114c9cd9304f0d55d899bb4b9329d0e22ac Mon Sep 17 00:00:00 2001 +>From 83012114c9cd9304f0d55d899bb4b9329d0e22ac Mon Sep 17 00:00:00 2001 From: Minchan Kim <minchan@kernel.org> Date: Tue, 8 Aug 2017 17:05:19 +0900 Subject: [PATCH] mm: decrease tlb flush pending count in tlb_finish_mmu diff --git a/a/content_digest b/N2/content_digest index 18881cd..2d58355 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -1,27 +1,9 @@ - "ref\020170802000818.4760-7-namit@vmware.com\0" - "ref\020170808011923.GE25554@yexl-desktop\0" - "ref\020170808022830.GA28570@bbox\0" - "ref\093CA4B47-95C2-43A2-8E92-B142CAB1DAF7@gmail.com\0" "ref\0970B5DC5-BFC2-461E-AC46-F71B3691D301@gmail.com\0" "From\0Minchan Kim <minchan@kernel.org>\0" - "Subject\0Re: [lkp-robot] [mm] 7674270022: will-it-scale.per_process_ops -19.3% regression\0" - "Date\0Tue, 8 Aug 2017 17:08:21 +0900\0" - "To\0Nadav Amit <nadav.amit@gmail.com>\0" - "Cc\0kernel test robot <xiaolong.ye@intel.com>" - open list:MEMORY MANAGEMENT <linux-mm@kvack.org> - LKML <linux-kernel@vger.kernel.org> - Andrew Morton <akpm@linux-foundation.org> - Ingo Molnar <mingo@redhat.com> - Russell King <linux@armlinux.org.uk> - Tony Luck <tony.luck@intel.com> - Martin Schwidefsky <schwidefsky@de.ibm.com> - David S. Miller <davem@davemloft.net> - Heiko Carstens <heiko.carstens@de.ibm.com> - Yoshinori Sato <ysato@users.sourceforge.jp> - Jeff Dike <jdike@addtoit.com> - linux-arch@vger.kernel.org - " lkp@01.org\0" - "\00:1\0" + "Subject\0Re: [lkp-robot] [mm] 7674270022: will-it-scale.per_process_ops -19.3% regression\0" + "Date\0Tue, 08 Aug 2017 17:08:21 +0900\0" + "To\0lkp@lists.01.org\0" + "\01:1\0" "b\0" "On Mon, Aug 07, 2017 at 10:51:00PM -0700, Nadav Amit wrote:\n" "> Nadav Amit <nadav.amit@gmail.com> wrote:\n" @@ -77,7 +59,7 @@ "Anyway, thanks for the pointing out.\n" "xiaolong.ye, could you retest with this fix?\n" "\n" - "From 83012114c9cd9304f0d55d899bb4b9329d0e22ac Mon Sep 17 00:00:00 2001\n" + ">From 83012114c9cd9304f0d55d899bb4b9329d0e22ac Mon Sep 17 00:00:00 2001\n" "From: Minchan Kim <minchan@kernel.org>\n" "Date: Tue, 8 Aug 2017 17:05:19 +0900\n" "Subject: [PATCH] mm: decrease tlb flush pending count in tlb_finish_mmu\n" @@ -106,4 +88,4 @@ "-- \n" 2.7.4 -cd04ce2ddf2a697084b70840ca75ff7e63949f856d5b7ad5b15acd05c55a37bc +6f71fe04fd7484f38e0d64734ee99270930b4b76b2d4c7d48d2275177db73f12
diff --git a/a/1.txt b/N3/1.txt index 876086e..0a8a080 100644 --- a/a/1.txt +++ b/N3/1.txt @@ -34,13 +34,13 @@ On Mon, Aug 07, 2017 at 10:51:00PM -0700, Nadav Amit wrote: > >> threads? > > > > According to the description it is "testcase:brk increase/decrease of one -> > page”. According to the mode it spawns multiple processes, not threads. +> > pagea??. According to the mode it spawns multiple processes, not threads. > > > > Since a single page is unmapped each time, and the iTLB-loads increase > > dramatically, I would suspect that for some reason a full TLB flush is > > caused during do_munmap(). > > -> > If I find some free time, I’ll try to profile the workload - but feel free +> > If I find some free time, Ia??ll try to profile the workload - but feel free > > to beat me to it. > > The root-cause appears to be that tlb_finish_mmu() does not call @@ -51,32 +51,3 @@ https://marc.info/?l=linux-mm&m=150156699114088&w=2 Anyway, thanks for the pointing out. xiaolong.ye, could you retest with this fix? - -From 83012114c9cd9304f0d55d899bb4b9329d0e22ac Mon Sep 17 00:00:00 2001 -From: Minchan Kim <minchan@kernel.org> -Date: Tue, 8 Aug 2017 17:05:19 +0900 -Subject: [PATCH] mm: decrease tlb flush pending count in tlb_finish_mmu - -The tlb pending count increased by tlb_gather_mmu should be decreased -at tlb_finish_mmu. Otherwise, A lot of TLB happens which makes -performance regression. - -Signed-off-by: Minchan Kim <minchan@kernel.org> ---- - mm/memory.c | 1 + - 1 file changed, 1 insertion(+) - -diff --git a/mm/memory.c b/mm/memory.c -index 34b1fcb829e4..ad2617552f55 100644 ---- a/mm/memory.c -+++ b/mm/memory.c -@@ -423,6 +423,7 @@ void tlb_finish_mmu(struct mmu_gather *tlb, - bool force = mm_tlb_flush_nested(tlb->mm); - - arch_tlb_finish_mmu(tlb, start, end, force); -+ dec_tlb_flush_pending(tlb->mm); - } - - /* --- -2.7.4 diff --git a/a/content_digest b/N3/content_digest index 18881cd..725f72e 100644 --- a/a/content_digest +++ b/N3/content_digest @@ -59,13 +59,13 @@ "> >> threads?\n" "> > \n" "> > According to the description it is \"testcase:brk increase/decrease of one\n" - "> > page\342\200\235. According to the mode it spawns multiple processes, not threads.\n" + "> > pagea??. According to the mode it spawns multiple processes, not threads.\n" "> > \n" "> > Since a single page is unmapped each time, and the iTLB-loads increase\n" "> > dramatically, I would suspect that for some reason a full TLB flush is\n" "> > caused during do_munmap().\n" "> > \n" - "> > If I find some free time, I\342\200\231ll try to profile the workload - but feel free\n" + "> > If I find some free time, Ia??ll try to profile the workload - but feel free\n" "> > to beat me to it.\n" "> \n" "> The root-cause appears to be that tlb_finish_mmu() does not call\n" @@ -75,35 +75,6 @@ "https://marc.info/?l=linux-mm&m=150156699114088&w=2\n" "\n" "Anyway, thanks for the pointing out.\n" - "xiaolong.ye, could you retest with this fix?\n" - "\n" - "From 83012114c9cd9304f0d55d899bb4b9329d0e22ac Mon Sep 17 00:00:00 2001\n" - "From: Minchan Kim <minchan@kernel.org>\n" - "Date: Tue, 8 Aug 2017 17:05:19 +0900\n" - "Subject: [PATCH] mm: decrease tlb flush pending count in tlb_finish_mmu\n" - "\n" - "The tlb pending count increased by tlb_gather_mmu should be decreased\n" - "at tlb_finish_mmu. Otherwise, A lot of TLB happens which makes\n" - "performance regression.\n" - "\n" - "Signed-off-by: Minchan Kim <minchan@kernel.org>\n" - "---\n" - " mm/memory.c | 1 +\n" - " 1 file changed, 1 insertion(+)\n" - "\n" - "diff --git a/mm/memory.c b/mm/memory.c\n" - "index 34b1fcb829e4..ad2617552f55 100644\n" - "--- a/mm/memory.c\n" - "+++ b/mm/memory.c\n" - "@@ -423,6 +423,7 @@ void tlb_finish_mmu(struct mmu_gather *tlb,\n" - " \tbool force = mm_tlb_flush_nested(tlb->mm);\n" - " \n" - " \tarch_tlb_finish_mmu(tlb, start, end, force);\n" - "+\tdec_tlb_flush_pending(tlb->mm);\n" - " }\n" - " \n" - " /*\n" - "-- \n" - 2.7.4 + xiaolong.ye, could you retest with this fix? -cd04ce2ddf2a697084b70840ca75ff7e63949f856d5b7ad5b15acd05c55a37bc +13bec42936560f789f1de01b9ab4fe7945ddd5028527e360abad88eda5181b32
diff --git a/a/1.txt b/N4/1.txt index 876086e..10769e2 100644 --- a/a/1.txt +++ b/N4/1.txt @@ -52,7 +52,7 @@ https://marc.info/?l=linux-mm&m=150156699114088&w=2 Anyway, thanks for the pointing out. xiaolong.ye, could you retest with this fix? -From 83012114c9cd9304f0d55d899bb4b9329d0e22ac Mon Sep 17 00:00:00 2001 +>From 83012114c9cd9304f0d55d899bb4b9329d0e22ac Mon Sep 17 00:00:00 2001 From: Minchan Kim <minchan@kernel.org> Date: Tue, 8 Aug 2017 17:05:19 +0900 Subject: [PATCH] mm: decrease tlb flush pending count in tlb_finish_mmu diff --git a/a/content_digest b/N4/content_digest index 18881cd..30738ab 100644 --- a/a/content_digest +++ b/N4/content_digest @@ -77,7 +77,7 @@ "Anyway, thanks for the pointing out.\n" "xiaolong.ye, could you retest with this fix?\n" "\n" - "From 83012114c9cd9304f0d55d899bb4b9329d0e22ac Mon Sep 17 00:00:00 2001\n" + ">From 83012114c9cd9304f0d55d899bb4b9329d0e22ac Mon Sep 17 00:00:00 2001\n" "From: Minchan Kim <minchan@kernel.org>\n" "Date: Tue, 8 Aug 2017 17:05:19 +0900\n" "Subject: [PATCH] mm: decrease tlb flush pending count in tlb_finish_mmu\n" @@ -106,4 +106,4 @@ "-- \n" 2.7.4 -cd04ce2ddf2a697084b70840ca75ff7e63949f856d5b7ad5b15acd05c55a37bc +e8114d64a8bf54ee1762b504772e30ace2a357a2a8ad619d0345d836182d9b31
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.