From: Cornelia Huck <cohuck@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Longpeng(Mike)" <longpeng2@huawei.com>,
rkrcmar@redhat.com, agraf@suse.com, borntraeger@de.ibm.com,
christoffer.dall@linaro.org, marc.zyngier@arm.com,
james.hogan@imgtec.com, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org, weidong.huang@huawei.com,
arei.gonglei@huawei.com, wangxinxin.wang@huawei.com,
longpeng.mike@gmail.com, david@redhat.com
Subject: Re: [PATCH v2 1/4] KVM: add spinlock optimization framework
Date: Tue, 8 Aug 2017 09:43:32 +0200 [thread overview]
Message-ID: <20170808094332.25dc10ef@gondolin> (raw)
In-Reply-To: <d0b4f5ee-205e-f711-3b85-9023ca20b5b4@redhat.com>
On Tue, 8 Aug 2017 09:34:14 +0200
Paolo Bonzini <pbonzini@redhat.com> wrote:
> On 08/08/2017 06:05, Longpeng(Mike) wrote:
> > return 1;
> > diff --git a/arch/s390/kvm/diag.c b/arch/s390/kvm/diag.c
> > index ce865bd..4ea8c38 100644
> > --- a/arch/s390/kvm/diag.c
> > +++ b/arch/s390/kvm/diag.c
> > @@ -150,7 +150,7 @@ static int __diag_time_slice_end(struct kvm_vcpu *vcpu)
> > {
> > VCPU_EVENT(vcpu, 5, "%s", "diag time slice end");
> > vcpu->stat.diagnose_44++;
> > - kvm_vcpu_on_spin(vcpu);
> > + kvm_vcpu_on_spin(vcpu, kvm_arch_vcpu_in_kernel(vcpu));
> > return 0;
> > }
> >
>
> IIUC, diag is a privileged instruction so this an also be "true".
>
> Paolo
Yes, indeed.
next prev parent reply other threads:[~2017-08-08 7:43 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-08 4:05 [PATCH v2 0/4] KVM: optimize the kvm_vcpu_on_spin Longpeng(Mike)
2017-08-08 4:05 ` [PATCH v2 1/4] KVM: add spinlock optimization framework Longpeng(Mike)
2017-08-08 7:34 ` Paolo Bonzini
2017-08-08 7:43 ` Cornelia Huck [this message]
2017-08-08 8:42 ` David Hildenbrand
2017-08-08 8:44 ` David Hildenbrand
2017-08-08 9:00 ` Paolo Bonzini
2017-08-08 9:35 ` Longpeng (Mike)
2017-08-08 4:05 ` [PATCH v2 2/4] KVM: X86: implement the logic for spinlock optimization Longpeng(Mike)
2017-08-08 7:30 ` Paolo Bonzini
2017-08-08 8:31 ` Longpeng (Mike)
2017-08-08 8:39 ` Paolo Bonzini
2017-08-08 4:05 ` [PATCH v2 3/4] KVM: s390: implements the kvm_arch_vcpu_in_kernel() Longpeng(Mike)
2017-08-08 7:37 ` Cornelia Huck
2017-08-08 8:35 ` David Hildenbrand
2017-08-08 4:05 ` [PATCH v2 4/4] KVM: arm: " Longpeng(Mike)
2017-08-08 7:39 ` Christoffer Dall
2017-08-08 7:41 ` Christoffer Dall
2017-08-08 7:41 ` [PATCH v2 0/4] KVM: optimize the kvm_vcpu_on_spin Cornelia Huck
2017-08-08 8:14 ` Longpeng (Mike)
2017-08-10 13:18 ` Eric Farman
2017-08-11 1:43 ` Longpeng (Mike)
2017-08-11 7:19 ` Cornelia Huck
2017-08-08 11:25 ` David Hildenbrand
2017-08-08 11:30 ` Christoffer Dall
2017-08-08 11:49 ` Longpeng (Mike)
2017-08-08 11:50 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170808094332.25dc10ef@gondolin \
--to=cohuck@redhat.com \
--cc=agraf@suse.com \
--cc=arei.gonglei@huawei.com \
--cc=borntraeger@de.ibm.com \
--cc=christoffer.dall@linaro.org \
--cc=david@redhat.com \
--cc=james.hogan@imgtec.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=longpeng.mike@gmail.com \
--cc=longpeng2@huawei.com \
--cc=marc.zyngier@arm.com \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=wangxinxin.wang@huawei.com \
--cc=weidong.huang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.