All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: xfs <linux-xfs@vger.kernel.org>
Subject: [PATCH 3/3] xfs: don't leak quotacheck dquots when cow recovery fails
Date: Tue, 8 Aug 2017 18:07:00 -0700	[thread overview]
Message-ID: <20170809010700.GA4461@magnolia> (raw)
In-Reply-To: <20170809010444.GR24087@magnolia>

If we fail a mount on account of cow recovery errors, it's possible that
a previous quotacheck left some dquots in memory.  The bailout clause of
xfs_mountfs forgets to purge these, and so we leak them.  Fix that.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
 fs/xfs/xfs_mount.c |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/fs/xfs/xfs_mount.c b/fs/xfs/xfs_mount.c
index d463ab3..8a12118 100644
--- a/fs/xfs/xfs_mount.c
+++ b/fs/xfs/xfs_mount.c
@@ -1029,6 +1029,8 @@ xfs_mountfs(
  out_agresv:
 	xfs_fs_unreserve_ag_blocks(mp);
  out_quota:
+	/* Clean out dquots that might be in memory after quotacheck. */
+	xfs_qm_unmount(mp);
 	xfs_qm_unmount_quotas(mp);
  out_rtunmount:
 	xfs_rtunmount_inodes(mp);

  parent reply	other threads:[~2017-08-09  1:07 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-09  1:04 [PATCH 1/3] xfs: clear MS_ACTIVE after finishing log recovery to avoid inode leak Darrick J. Wong
2017-08-09  1:06 ` [PATCH 2/3] xfs: don't leak linked inodes during log recovery Darrick J. Wong
2017-08-09 12:36   ` Brian Foster
2017-08-09 16:49     ` Darrick J. Wong
2017-08-09 17:17       ` Brian Foster
2017-08-09  1:07 ` Darrick J. Wong [this message]
2017-08-09 12:36   ` [PATCH 3/3] xfs: don't leak quotacheck dquots when cow recovery fails Brian Foster
2017-08-09 16:06     ` Darrick J. Wong
2017-08-09  6:31 ` [PATCH 1/3] xfs: clear MS_ACTIVE after finishing log recovery to avoid inode leak Nikolay Borisov
2017-08-09 12:36 ` Brian Foster
2017-08-09 15:46   ` Darrick J. Wong
  -- strict thread matches above, loose matches on Subject: below --
2017-08-10  5:23 Darrick J. Wong
2017-08-10  5:23 ` [PATCH 3/3] xfs: don't leak quotacheck dquots when cow recovery fails Darrick J. Wong
2017-08-10 14:51   ` Brian Foster
2017-08-11 11:19   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170809010700.GA4461@magnolia \
    --to=darrick.wong@oracle.com \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.