All of lore.kernel.org
 help / color / mirror / Atom feed
From: Samuel Mendoza-Jonas <sam@mendozajonas.com>
To: openbmc@lists.ozlabs.org
Cc: Samuel Mendoza-Jonas <sam@mendozajonas.com>,
	Joel Stanley <joel@jms.id.au>,
	Ravindra S Rao1 <ravindra.s@in.ibm.com>,
	Leonard Low <leolow@au1.ibm.com>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Ratan K Gupta <ratagupt@in.ibm.com>
Subject: [RFC PATCH 1/3] ftgmac: Include NETIF_F_HW_VLAN_CTAG_FILTER in features
Date: Wed,  9 Aug 2017 18:54:41 +1000	[thread overview]
Message-ID: <20170809085443.13148-2-sam@mendozajonas.com> (raw)
In-Reply-To: <20170809085443.13148-1-sam@mendozajonas.com>

This is required for the VLAN core to call the add/kill callback for
VLAN IDs.

Signed-off-by: Samuel Mendoza-Jonas <sam@mendozajonas.com>
---
 drivers/net/ethernet/faraday/ftgmac100.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/net/ethernet/faraday/ftgmac100.c b/drivers/net/ethernet/faraday/ftgmac100.c
index 33b5c8eb9961..7c4d772287c7 100644
--- a/drivers/net/ethernet/faraday/ftgmac100.c
+++ b/drivers/net/ethernet/faraday/ftgmac100.c
@@ -1837,6 +1837,9 @@ static int ftgmac100_probe(struct platform_device *pdev)
 		NETIF_F_GRO | NETIF_F_SG | NETIF_F_HW_VLAN_CTAG_RX |
 		NETIF_F_HW_VLAN_CTAG_TX;
 
+	if (priv->use_ncsi)
+		netdev->hw_features |= NETIF_F_HW_VLAN_CTAG_FILTER;
+
 	/* AST2400  doesn't have working HW checksum generation */
 	if (np && (of_device_is_compatible(np, "aspeed,ast2400-mac")))
 		netdev->hw_features &= ~NETIF_F_HW_CSUM;
-- 
2.13.3

  reply	other threads:[~2017-08-09  9:01 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-09  8:54 [RFC PATCH 0/3] NCSI VLAN Filtering Support Samuel Mendoza-Jonas
2017-08-09  8:54 ` Samuel Mendoza-Jonas [this message]
2017-08-10  7:49   ` [RFC PATCH 1/3] ftgmac: Include NETIF_F_HW_VLAN_CTAG_FILTER in features Joel Stanley
2017-08-10 11:30     ` Benjamin Herrenschmidt
2017-08-11  0:05       ` Joel Stanley
2017-08-09  8:54 ` [RFC PATCH 2/3] net/ncsi: Fix several packet definitions Samuel Mendoza-Jonas
2017-08-10  7:03   ` Joel Stanley
2017-08-10 11:28     ` Benjamin Herrenschmidt
2017-08-10 22:39     ` Samuel Mendoza-Jonas
2017-08-11  0:11       ` Joel Stanley
2017-08-09  8:54 ` [RFC PATCH 3/3] net/ncsi: Configure VLAN tag filter Samuel Mendoza-Jonas
2017-08-10  7:49   ` Joel Stanley
2017-08-10 22:42     ` Samuel Mendoza-Jonas
2017-08-10  8:25   ` Joel Stanley
2017-08-10 22:45     ` Samuel Mendoza-Jonas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170809085443.13148-2-sam@mendozajonas.com \
    --to=sam@mendozajonas.com \
    --cc=benh@kernel.crashing.org \
    --cc=joel@jms.id.au \
    --cc=leolow@au1.ibm.com \
    --cc=openbmc@lists.ozlabs.org \
    --cc=ratagupt@in.ibm.com \
    --cc=ravindra.s@in.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.