From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH 2/4] net-next: dsa: add flow_dissect callback to struct dsa_device_ops Date: Wed, 9 Aug 2017 15:51:59 +0200 Message-ID: <20170809135159.GD30723@lunn.ch> References: <20170809124119.24320-1-john@phrozen.org> <20170809124119.24320-3-john@phrozen.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20170809124119.24320-3-john-Pj+rj9U5foFAfugRpC6u6w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+glpam-linux-mediatek=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: John Crispin Cc: Florian Fainelli , Muciri Gatimu , Vivien Didelot , netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Sean Wang , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Shashidhar Lakkavalli , "David S . Miller" List-Id: linux-mediatek@lists.infradead.org On Wed, Aug 09, 2017 at 02:41:17PM +0200, John Crispin wrote: > When the flow dissector first sees packets coming in on a DSA devices the > 802.3 header wont be located where the code expects it to be as the tag > is still present. Adding this new callback allows a DSA device to provide a > new function that the flow_dissector can use to get the correct protocol > and offset of the network header. > > Signed-off-by: Muciri Gatimu > Signed-off-by: Shashidhar Lakkavalli > Signed-off-by: John Crispin Reviewed-by: Andrew Lunn Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752732AbdHINwb (ORCPT ); Wed, 9 Aug 2017 09:52:31 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:58391 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752652AbdHINwa (ORCPT ); Wed, 9 Aug 2017 09:52:30 -0400 Date: Wed, 9 Aug 2017 15:51:59 +0200 From: Andrew Lunn To: John Crispin Cc: Vivien Didelot , Florian Fainelli , "David S . Miller" , Sean Wang , netdev@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, Muciri Gatimu , Shashidhar Lakkavalli Subject: Re: [PATCH 2/4] net-next: dsa: add flow_dissect callback to struct dsa_device_ops Message-ID: <20170809135159.GD30723@lunn.ch> References: <20170809124119.24320-1-john@phrozen.org> <20170809124119.24320-3-john@phrozen.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170809124119.24320-3-john@phrozen.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 09, 2017 at 02:41:17PM +0200, John Crispin wrote: > When the flow dissector first sees packets coming in on a DSA devices the > 802.3 header wont be located where the code expects it to be as the tag > is still present. Adding this new callback allows a DSA device to provide a > new function that the flow_dissector can use to get the correct protocol > and offset of the network header. > > Signed-off-by: Muciri Gatimu > Signed-off-by: Shashidhar Lakkavalli > Signed-off-by: John Crispin Reviewed-by: Andrew Lunn Andrew