All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Thomas Richter <tmricht@linux.vnet.ibm.com>
Cc: acme@kernel.org, linux-perf-users@vger.kernel.org,
	brueckner@linux.vnet.ibm.com
Subject: Re: [PATCH 9/9] perf: test 15 fix expected task value.
Date: Wed, 9 Aug 2017 17:01:16 +0200	[thread overview]
Message-ID: <20170809150116.GA23060@krava> (raw)
In-Reply-To: <20170809064040.50899-9-tmricht@linux.vnet.ibm.com>

On Wed, Aug 09, 2017 at 08:40:40AM +0200, Thomas Richter wrote:
> Running perf test 15 (event attr test) the expected value
> for task is 1. This can be seen with:

I just sent email to Arnaldo (you're in CC), fix for this was already posted

jirka

> 
> [root@oc2666213455 ~]# perf record -vv -b -- sleep 1
> ------------------------------------------------------------
> perf_event_attr:
>   size                             104
>   { sample_period, sample_freq }   4000
>   sample_type                      IP|TID|TIME|PERIOD|BRANCH_STACK
>   disabled                         1
>   inherit                          1
>   mmap                             1
>   comm                             1
>   freq                             1
>   enable_on_exec                   1
>   task                             1
>   sample_id_all                    1
>   exclude_guest                    1
>   mmap2                            1
>   comm_exec                        1
> ------------------------------------------------------------
> [...]
> 
> Change the expected task value from 0 to 1 in the base-record
> file to match the correct results and report success for the
> test-record-* test cases.
> 
> Signed-off-by: Thomas Richter <tmricht@linux.vnet.ibm.com>
> ---
>  tools/perf/tests/attr/base-record | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/tests/attr/base-record b/tools/perf/tests/attr/base-record
> index 31e0b1d..3794066 100644
> --- a/tools/perf/tests/attr/base-record
> +++ b/tools/perf/tests/attr/base-record
> @@ -23,7 +23,7 @@ comm=1
>  freq=1
>  inherit_stat=0
>  enable_on_exec=1
> -task=0
> +task=1
>  watermark=0
>  precise_ip=0|1|2|3
>  mmap_data=0
> -- 
> 2.9.3
> 

  reply	other threads:[~2017-08-09 15:01 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-09  6:40 [PATCH 1/9] perf: test 15 fix python error on empty result Thomas Richter
2017-08-09  6:40 ` [PATCH 2/9] perf test: perf test case 15 result ignored Thomas Richter
2017-08-09  6:40 ` [PATCH 3/9] perf: test 15 fix test-stat-group tests Thomas Richter
2017-08-09 15:15   ` Jiri Olsa
2017-08-09  6:40 ` [PATCH 4/9] perf: test 15 add s390x support for stat test cases Thomas Richter
2017-08-09 15:22   ` Jiri Olsa
2017-08-10  7:15     ` Thomas Richter
2017-08-09  6:40 ` [PATCH 5/9] perf test 15: disable test-record-group tests on s390x Thomas Richter
2017-08-09  6:40 ` [PATCH 6/9] perf test 15: disable test-record-filter " Thomas Richter
2017-08-09  6:40 ` [PATCH 7/9] perf test 15: disable test-record-graph-dwarf test " Thomas Richter
2017-08-09  6:40 ` [PATCH 8/9] perf: test 15 change period and frequency for s390x Thomas Richter
2017-08-09  6:40 ` [PATCH 9/9] perf: test 15 fix expected task value Thomas Richter
2017-08-09 15:01   ` Jiri Olsa [this message]
2017-08-09 10:39 ` [PATCH 1/9] perf: test 15 fix python error on empty result Jiri Olsa
2017-08-09 11:02   ` Thomas-Mich Richter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170809150116.GA23060@krava \
    --to=jolsa@redhat.com \
    --cc=acme@kernel.org \
    --cc=brueckner@linux.vnet.ibm.com \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=tmricht@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.