From: Christoph Hellwig <hch@lst.de>
To: axboe@kernel.dk
Cc: mpatocka@redhat.com, gmazyland@gmail.com,
martin.petersen@oracle.com, linux-block@vger.kernel.org,
dm-devel@redhat.com
Subject: [PATCH 1/2] bio-integrity: move the bio integrity profile check earlier in bio_integrity_prep
Date: Wed, 9 Aug 2017 17:48:08 +0200 [thread overview]
Message-ID: <20170809154809.2168-2-hch@lst.de> (raw)
In-Reply-To: <20170809154809.2168-1-hch@lst.de>
This makes the code more obvious, and moves the most likely branch first
in the function.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
block/bio-integrity.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/block/bio-integrity.c b/block/bio-integrity.c
index 9b1ea478577b..fafd19c540b0 100644
--- a/block/bio-integrity.c
+++ b/block/bio-integrity.c
@@ -246,6 +246,9 @@ bool bio_integrity_prep(struct bio *bio)
blk_status_t status;
bi = bdev_get_integrity(bio->bi_bdev);
+ if (!bi)
+ return true;
+
q = bdev_get_queue(bio->bi_bdev);
if (bio_op(bio) != REQ_OP_READ && bio_op(bio) != REQ_OP_WRITE)
return true;
@@ -257,9 +260,6 @@ bool bio_integrity_prep(struct bio *bio)
if (bio_integrity(bio))
return true;
- if (bi == NULL)
- return true;
-
if (bio_data_dir(bio) == READ) {
if (!bi->profile->verify_fn ||
!(bi->flags & BLK_INTEGRITY_VERIFY))
--
2.11.0
next prev parent reply other threads:[~2017-08-09 15:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-09 15:48 two small integrity cleanups Christoph Hellwig
2017-08-09 15:48 ` Christoph Hellwig [this message]
2017-08-09 15:48 ` [PATCH 2/2] dm-crypt: don't mess with BIP_BLOCK_INTEGRITY Christoph Hellwig
2017-08-09 16:00 ` two small integrity cleanups Jens Axboe
2017-08-09 16:22 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170809154809.2168-2-hch@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=gmazyland@gmail.com \
--cc=linux-block@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mpatocka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.