From: Ido Schimmel <idosch@idosch.org>
To: Florian Westphal <fw@strlen.de>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH v2 net-next 5/7] rtnetlink: protect handler table with rcu
Date: Thu, 10 Aug 2017 11:26:47 +0300 [thread overview]
Message-ID: <20170810082647.GA11516@splinter> (raw)
In-Reply-To: <20170809184153.16700-6-fw@strlen.de>
On Wed, Aug 09, 2017 at 08:41:51PM +0200, Florian Westphal wrote:
> Note that netlink dumps still acquire rtnl mutex via the netlink
> dump infrastructure.
>
> Signed-off-by: Florian Westphal <fw@strlen.de>
> Reviewed-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
Florian, can you please check the following splat? I didn't bisect, but
looks like it's related to this patch.
Thanks
[ 2.940093] =============================
[ 2.944145] WARNING: suspicious RCU usage
[ 2.948147] 4.13.0-rc4-idosch-next-custom #565 Not tainted
[ 2.954116] -----------------------------
[ 2.958113] net/core/rtnetlink.c:175 suspicious rcu_dereference_check() usage!
[ 2.965116]
[ 2.965116] other info that might help us debug this:
[ 2.965116]
[ 2.973123]
[ 2.973123] rcu_scheduler_active = 1, debug_locks = 1
[ 2.979119] no locks held by swapper/0/1.
[ 2.983109]
[ 2.983109] stack backtrace:
[ 2.988117] CPU: 1 PID: 1 Comm: swapper/0 Not tainted 4.13.0-rc4-idosch-next-custom #565
[ 2.989000] Hardware name: Mellanox Technologies Ltd. Mellanox switch/Mellanox switch, BIOS 4.6.5 05/21/2015
[ 2.989000] Call Trace:
[ 2.989000] dump_stack+0xb1/0x10c
[ 2.989000] ? _atomic_dec_and_lock+0x124/0x124
[ 2.989000] ? lockdep_print_held_locks+0x9b/0xf0
[ 2.989000] lockdep_rcu_suspicious+0xdd/0x110
[ 2.989000] __rtnl_register+0x1c1/0x320
[ 2.989000] ? rtnetlink_bind+0x50/0x50
[ 2.989000] ? net_defaults_init+0x29/0x29
[ 2.989000] rtnl_register+0x11/0x30
[ 2.989000] net_ns_init+0x1bd/0x1fd
[ 2.989000] ? net_defaults_init+0x29/0x29
[ 2.989000] ? __init_srcu_struct+0x54/0x60
[ 2.989000] ? srcu_init_notifier_head+0x4a/0x80
[ 2.989000] do_one_initcall+0x9a/0x241
[ 2.989000] ? initcall_blacklisted+0x140/0x140
[ 2.989000] ? up_read+0x40/0x40
[ 2.989000] ? _raw_spin_unlock_irqrestore+0x3d/0x60
[ 2.989000] ? __wake_up+0x3f/0x50
[ 2.989000] kernel_init_freeable+0x3ea/0x485
[ 2.989000] ? rest_init+0x100/0x100
[ 2.989000] kernel_init+0xe/0x140
[ 2.989000] ? rest_init+0x100/0x100
[ 2.989000] ? rest_init+0x100/0x100
[ 2.989000] ret_from_fork+0x27/0x40
next prev parent reply other threads:[~2017-08-10 8:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-09 18:41 [PATCH v2 net-next 0/7] rtnetlink: allow selected handlers to run without rtnl Florian Westphal
2017-08-09 18:41 ` [PATCH v2 net-next 1/7] rtnetlink: call rtnl_calcit directly Florian Westphal
2017-08-09 18:41 ` [PATCH v2 net-next 2/7] rtnetlink: make rtnl_register accept a flags parameter Florian Westphal
2017-08-09 18:41 ` [PATCH v2 net-next 3/7] rtnetlink: add reference counting to prevent module unload while dump is in progress Florian Westphal
2017-08-09 18:41 ` [PATCH v2 net-next 4/7] rtnetlink: small rtnl lock pushdown Florian Westphal
2017-08-09 18:41 ` [PATCH v2 net-next 5/7] rtnetlink: protect handler table with rcu Florian Westphal
2017-08-10 8:26 ` Ido Schimmel [this message]
2017-08-09 18:41 ` [PATCH v2 net-next 6/7] rtnetlink: add RTNL_FLAG_DOIT_UNLOCKED Florian Westphal
2017-08-09 18:41 ` [PATCH v2 net-next 7/7] net: call newid/getid without rtnl mutex held Florian Westphal
2017-08-10 0:21 ` [PATCH v2 net-next 0/7] rtnetlink: allow selected handlers to run without rtnl David Miller
2017-08-10 1:27 ` David Ahern
2017-08-10 11:29 ` Florian Westphal
2017-08-10 16:23 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170810082647.GA11516@splinter \
--to=idosch@idosch.org \
--cc=fw@strlen.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.