From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from ec2-52-27-115-49.us-west-2.compute.amazonaws.com ([52.27.115.49]:57189 "EHLO osg.samsung.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751492AbdHKARa (ORCPT ); Thu, 10 Aug 2017 20:17:30 -0400 Date: Thu, 10 Aug 2017 21:17:23 -0300 From: Mauro Carvalho Chehab To: Hans Verkuil Cc: Linux Media Mailing List Subject: Re: [PATCH] v4l2-compat-ioctl32.c: add capabilities field to, v4l2_input32 Message-ID: <20170810211723.3223c9ee@vento.lan> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Em Fri, 4 Aug 2017 13:25:06 +0200 Hans Verkuil escreveu: > The v4l2_input32 struct wasn't updated when this field was added. > It didn't cause a failure in the compat code, but it is better to > keep it in sync with v4l2_input to avoid confusion. > > Signed-off-by: Hans Verkuil Looks good to me. Reviewed-by: Mauro Carvalho Chehab > --- > drivers/media/v4l2-core/v4l2-compat-ioctl32.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/v4l2-core/v4l2-compat-ioctl32.c b/drivers/media/v4l2-core/v4l2-compat-ioctl32.c > index 6f52970f8b54..90827073066f 100644 > --- a/drivers/media/v4l2-core/v4l2-compat-ioctl32.c > +++ b/drivers/media/v4l2-core/v4l2-compat-ioctl32.c > @@ -627,7 +627,8 @@ struct v4l2_input32 { > __u32 tuner; /* Associated tuner */ > compat_u64 std; > __u32 status; > - __u32 reserved[4]; > + __u32 capabilities; > + __u32 reserved[3]; > }; > > /* The 64-bit v4l2_input struct has extra padding at the end of the struct. Thanks, Mauro