From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753085AbdHKMvN (ORCPT ); Fri, 11 Aug 2017 08:51:13 -0400 Received: from mail-wr0-f194.google.com ([209.85.128.194]:33047 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752883AbdHKMvL (ORCPT ); Fri, 11 Aug 2017 08:51:11 -0400 Date: Fri, 11 Aug 2017 14:51:07 +0200 From: Ingo Molnar To: Juergen Gross Cc: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, hpa@zytor.com, tglx@linutronix.de, mingo@redhat.com, Boris Ostrovsky Subject: Re: [PATCH v2 0/3] fix xen hvm guest with kaslr enabled Message-ID: <20170811125107.f5nflg2bffalg6hf@gmail.com> References: <20170728102314.29100-1-jgross@suse.com> <8a07a112-ffc2-885a-95d3-bb4ba7658a83@suse.com> <7c78d567-fd19-0c9b-9af0-8465e70993fa@oracle.com> <99bef8e4-34f3-54dc-5790-7fa2db4e3787@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <99bef8e4-34f3-54dc-5790-7fa2db4e3787@suse.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Juergen Gross wrote: > On 08/08/17 16:00, Boris Ostrovsky wrote: > > On 08/08/2017 02:46 AM, Juergen Gross wrote: > >> On 28/07/17 12:23, Juergen Gross wrote: > >>> This patch series fixes a regression introduced in 4.13-rc1: A Xen > >>> HVM guest with KASLR enabled wouldn't boot any longer due to the usage > >>> of __va() before kernel_randomize_memory() was called. > >>> > >>> Changes in V2: > >>> - patch 1: test for x86_hyper being not NULL > >>> > >>> Juergen Gross (3): > >>> x86: provide an init_mem_mapping hypervisor hook > >>> xen: split up xen_hvm_init_shared_info() > >>> xen: fix hvm guest with kaslr enabled > >>> > >>> arch/x86/include/asm/hypervisor.h | 10 +++++++ > >>> arch/x86/mm/init.c | 3 ++ > >>> arch/x86/xen/enlighten_hvm.c | 59 ++++++++++++++++++++++++--------------- > >>> 3 files changed, 50 insertions(+), 22 deletions(-) > >>> > >> Could I have some feedback, please? > >> > >> I'd like to get this regression fixed in 4.13. > >> > >> In case nobody objects this week I'll just add the patches to the Xen > >> tree for rc5. > > > > > > As I said before I think .init_mem_mapping() could live in > > x86_platform_ops() but this works too, so > > > > Reviewed-by: Boris Ostrovsky > > > > But this still wants x86 maintainers' ACK. > > x86 maintainers, could you please comment on at least patch 1? LGTM: Acked-by: Ingo Molnar Thanks, Ingo