diff for duplicates of <20170811132526.GD25147@Red> diff --git a/a/1.txt b/N1/1.txt index ef54da2..47f754e 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -40,11 +40,11 @@ On Fri, Aug 11, 2017 at 04:22:11PM +0800, Chen-Yu Tsai wrote: > >> > >> That is just the label. The label plays no part in device tree merging. The path > >> -> >> /soc/ethernet at 1c30000/mdio/ethernet-phy at 1 +> >> /soc/ethernet@1c30000/mdio/ethernet-phy@1 > >> > >> is the same. You can look under > >> -> >> /proc/device-tree/soc/ethernet at 1c30000/mdio +> >> /proc/device-tree/soc/ethernet@1c30000/mdio > >> > >> on the OrangePI Plus 2E or any other H3 board that uses an > >> external PHY at address 1. @@ -60,9 +60,9 @@ On Fri, Aug 11, 2017 at 04:22:11PM +0800, Chen-Yu Tsai wrote: Hello Rob, florian, mark -Adding a delete property on all external ethernet-phy at 1 is a bit overkill, and I dont like the idea that nodes are merged. +Adding a delete property on all external ethernet-phy@1 is a bit overkill, and I dont like the idea that nodes are merged. What do you think about other possible solutions: -- Using integrated-phy at 1 for the integrated PHY node name +- Using integrated-phy@1 for the integrated PHY node name - Using a fake address like 31 (see patch below) If you have any other solution... @@ -76,7 +76,7 @@ Subject: [PATCH] ARM: sun8i: sunxi-h3-h5: Prevent merge of external and integrated PHY Actually, some external and integrated PHY are merged due to same dtnode -name "ethernet-phy at 1". +name "ethernet-phy@1". This is problematic when we will want to use the phy-is-integrated property. (Need to delete it on all external PHY node) @@ -99,16 +99,16 @@ index 54fc24e4c569..2110b0069e33 100644 mdio: mdio { #address-cells = <1>; #size-cells = <0>; -- int_mii_phy: ethernet-phy at 1 { +- int_mii_phy: ethernet-phy@1 { + /* + * Using 31 permits to make a separation between + * this integrated PHY and external ones. -+ * Without it, external "ethernet-phy at 1" will be ++ * Without it, external "ethernet-phy@1" will be + * merged with it (due to same dtnode name). + * Board makers currently only provides PHY at + * addresses 1 and 7. + */ -+ int_mii_phy: ethernet-phy at 31 { ++ int_mii_phy: ethernet-phy@31 { compatible = "ethernet-phy-ieee802.3-c22"; reg = <1>; clocks = <&ccu CLK_BUS_EPHY>; diff --git a/a/content_digest b/N1/content_digest index 2ef0427..f325298 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -5,10 +5,22 @@ "ref\0CAGb2v66wCRe8nFucJa5nAT1GhO75LmCyfNWQQbwxzh085Zwk+w@mail.gmail.com\0" "ref\020170811081920.GB25147@Red\0" "ref\0CAGb2v66SGAKnFoHNqWR+DqS-mY3KA853NmKpdHqf8huOkisLKg@mail.gmail.com\0" - "From\0clabbe.montjoie@gmail.com (Corentin Labbe)\0" - "Subject\0[PATCH 2/3] ARM: sun8i: sunxi-h3-h5: add phy-is-integrated property to internal PHY\0" + "From\0Corentin Labbe <clabbe.montjoie@gmail.com>\0" + "Subject\0Re: [PATCH 2/3] ARM: sun8i: sunxi-h3-h5: add phy-is-integrated property to internal PHY\0" "Date\0Fri, 11 Aug 2017 15:25:26 +0200\0" - "To\0linux-arm-kernel@lists.infradead.org\0" + "To\0Chen-Yu Tsai <wens@csie.org>" + robh+dt@kernel.org + mark.rutland@arm.com + " f.fainelli@gmail.com\0" + "Cc\0Russell King <linux@armlinux.org.uk>" + Maxime Ripard <maxime.ripard@free-electrons.com> + Giuseppe Cavallaro <peppe.cavallaro@st.com> + alexandre.torgue@st.com + netdev <netdev@vger.kernel.org> + devicetree <devicetree@vger.kernel.org> + linux-kernel <linux-kernel@vger.kernel.org> + linux-arm-kernel <linux-arm-kernel@lists.infradead.org> + " andrew@lunn.ch\0" "\00:1\0" "b\0" "On Fri, Aug 11, 2017 at 04:22:11PM +0800, Chen-Yu Tsai wrote:\n" @@ -53,11 +65,11 @@ "> >>\n" "> >> That is just the label. The label plays no part in device tree merging. The path\n" "> >>\n" - "> >> /soc/ethernet at 1c30000/mdio/ethernet-phy at 1\n" + "> >> /soc/ethernet@1c30000/mdio/ethernet-phy@1\n" "> >>\n" "> >> is the same. You can look under\n" "> >>\n" - "> >> /proc/device-tree/soc/ethernet at 1c30000/mdio\n" + "> >> /proc/device-tree/soc/ethernet@1c30000/mdio\n" "> >>\n" "> >> on the OrangePI Plus 2E or any other H3 board that uses an\n" "> >> external PHY at address 1.\n" @@ -73,9 +85,9 @@ "\n" "Hello Rob, florian, mark\n" "\n" - "Adding a delete property on all external ethernet-phy at 1 is a bit overkill, and I dont like the idea that nodes are merged.\n" + "Adding a delete property on all external ethernet-phy@1 is a bit overkill, and I dont like the idea that nodes are merged.\n" "What do you think about other possible solutions:\n" - "- Using integrated-phy at 1 for the integrated PHY node name\n" + "- Using integrated-phy@1 for the integrated PHY node name\n" "- Using a fake address like 31 (see patch below)\n" "\n" "If you have any other solution...\n" @@ -89,7 +101,7 @@ " integrated PHY\n" "\n" "Actually, some external and integrated PHY are merged due to same dtnode\n" - "name \"ethernet-phy at 1\".\n" + "name \"ethernet-phy@1\".\n" "\n" "This is problematic when we will want to use the phy-is-integrated\n" "property. (Need to delete it on all external PHY node)\n" @@ -112,20 +124,20 @@ " \t\t\tmdio: mdio {\n" " \t\t\t\t#address-cells = <1>;\n" " \t\t\t\t#size-cells = <0>;\n" - "-\t\t\t\tint_mii_phy: ethernet-phy at 1 {\n" + "-\t\t\t\tint_mii_phy: ethernet-phy@1 {\n" "+\t\t\t\t/*\n" "+\t\t\t\t * Using 31 permits to make a separation between\n" "+\t\t\t\t * this integrated PHY and external ones.\n" - "+\t\t\t\t * Without it, external \"ethernet-phy at 1\" will be\n" + "+\t\t\t\t * Without it, external \"ethernet-phy@1\" will be\n" "+\t\t\t\t * merged with it (due to same dtnode name).\n" "+\t\t\t\t * Board makers currently only provides PHY at\n" "+\t\t\t\t * addresses 1 and 7.\n" "+\t\t\t\t */\n" - "+\t\t\t\tint_mii_phy: ethernet-phy at 31 {\n" + "+\t\t\t\tint_mii_phy: ethernet-phy@31 {\n" " \t\t\t\t\tcompatible = \"ethernet-phy-ieee802.3-c22\";\n" " \t\t\t\t\treg = <1>;\n" " \t\t\t\t\tclocks = <&ccu CLK_BUS_EPHY>;\n" "-- \n" 2.13.0 -2c667707cec72e568a32f41ac35a646c3195698613d414ac6e36134c44deb41e +71c68054ab72a4741d9eb7e0250b032dbfbc9b628f7628fab6eefd371dd19647
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.