Re: [PATCH net-next v2] vxlan: change vxlan_[config_]validate() to use netlink_ext_ack for error reporting

[Jiri Benc <jbenc@redhat.com>]

On Thu, 10 Aug 2017 14:16:35 -0700, Girish Moodalbail wrote:
> +			NL_SET_ERR_MSG_ATTR(extack, tb[IFLA_VXLAN_PORT_RANGE],
> +					    "Provided source port range bounds is invalid");

s/bounds//?

> +	if (conf->label && !use_ipv6) {
> +		NL_SET_ERR_MSG(extack,
> +			       "Label attribute only applies for IPv6 VXLAN devices");

applies to

> +		if (!lowerdev) {
> +			NL_SET_ERR_MSG(extack,
> +				       "Specified interface for tunnel endpoint communications not found");

s/communications//?

> +		if (vxlan_addr_multicast(&conf->remote_ip)) {
> +			NL_SET_ERR_MSG(extack,
> +				       "Interface need to be specified for multicast destination");

needs

> +		if (conf->flags & VXLAN_F_IPV6_LINKLOCAL) {
> +			NL_SET_ERR_MSG(extack,
> +				       "Interface need to be specified for link-local local/remote addresses");

needs

Looks good to me otherwise, thanks!

 Jiri